Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 2265553002: Stub out Document::syncAnnotScan method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by tonikitoo
Modified:
7 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Stub out Document::syncAnnotScan method. The PDF specification [1] says: " syncAnnotScan guarantees that all annotations will be scanned by the time this method returns. (..) Normally a background task runs that examine every page and looks for annotations during idle times. " The statement details specifically how Acrobat implements this method. Although, neither the method itself nor the background scanner task are implemented in PDFium (as of today, Ago/2016), not having ::syncAnnotScan at least stubbed out can be considered harmfull since its absence makes JS acrobat scripts silently fail when it has a call to it. Given that, and following a stub-out pattern present in other methods including ::addAnnot and ::addField, CL provides a stubbed out implementation of Document::syncAnnotScan. [1] http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/js_api_reference.pdf BUG=pdfium:492 Committed: https://pdfium.googlesource.com/pdfium/+/bb5fa043a7ef2de165c7903548e5663a6f8bcf9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M fpdfsdk/javascript/Document.h View 2 chunks +5 lines, -0 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M testing/resources/javascript/document_methods.in View 1 chunk +1 line, -0 lines 0 comments Download
M testing/resources/javascript/document_methods_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (4 generated)
tonikitoo
PTAL
7 months ago (2016-08-19 16:16:16 UTC) #3
Tom Sepez
lgtm
7 months ago (2016-08-19 17:35:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265553002/1
7 months ago (2016-08-19 17:35:45 UTC) #6
commit-bot: I haz the power
7 months ago (2016-08-19 18:18:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bb5fa043a7ef2de165c7903548e5663a6f8b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62