Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2265553002: Stub out Document::syncAnnotScan method. (Closed)

3 years ago by tonikitoo
3 years ago
Base URL:
Target Ref:


Stub out Document::syncAnnotScan method. The PDF specification [1] says: " syncAnnotScan guarantees that all annotations will be scanned by the time this method returns. (..) Normally a background task runs that examine every page and looks for annotations during idle times. " The statement details specifically how Acrobat implements this method. Although, neither the method itself nor the background scanner task are implemented in PDFium (as of today, Ago/2016), not having ::syncAnnotScan at least stubbed out can be considered harmfull since its absence makes JS acrobat scripts silently fail when it has a call to it. Given that, and following a stub-out pattern present in other methods including ::addAnnot and ::addField, CL provides a stubbed out implementation of Document::syncAnnotScan. [1] BUG=pdfium:492 Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M fpdfsdk/javascript/Document.h View 2 chunks +5 lines, -0 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M testing/resources/javascript/ View 1 chunk +1 line, -0 lines 0 comments Download
M testing/resources/javascript/document_methods_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download


Total messages: 8 (4 generated)
3 years ago (2016-08-19 16:16:16 UTC) #3
Tom Sepez
3 years ago (2016-08-19 17:35:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at
3 years ago (2016-08-19 17:35:45 UTC) #6
commit-bot: I haz the power
3 years ago (2016-08-19 18:18:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as

Powered by Google App Engine
This is Rietveld 408576698