Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2265513003: Converted Observatory object-common element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed typos #

Total comments: 9

Patch Set 3 : Updated observatory_sources.gypi #

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1177 lines, -279 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 2 chunks +45 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/inbound_reference.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D runtime/observatory/lib/src/elements/inbound_reference.html View 1 chunk +0 lines, -33 lines 0 comments Download
A runtime/observatory/lib/src/elements/inbound_references.dart View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.dart View 1 2 3 1 chunk +196 lines, -35 lines 0 comments Download
D runtime/observatory/lib/src/elements/object_common.html View 1 chunk +0 lines, -120 lines 0 comments Download
A runtime/observatory/lib/src/elements/object_common_wrapper.dart View 1 chunk +111 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/elements/retaining_path.dart View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/inbound_references.dart View 1 chunk +10 lines, -8 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/retaining_path.dart View 1 chunk +12 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/inbound_references.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/reachable_size.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/retained_size.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/retaining_path.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A runtime/observatory/lib/src/repositories/inbound_references.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/reachable_size.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/retained_size.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/retaining_path.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 5 chunks +47 lines, -5 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 7 chunks +13 lines, -3 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/inbound_references/element_test.dart View 1 1 chunk +61 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/inbound_references/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 3 chunks +7 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/guarded.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/inbound_references.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart View 1 chunk +2 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/retaining_path.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/inbound_references.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/reachable_size.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/retained_size.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/retaining_path.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/object_common/element_test.dart View 1 chunk +111 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/object_common/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/retaining_path/element_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/retaining_path/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-19 17:37:59 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-19 21:48:59 UTC) #3
Cutch
https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart File runtime/observatory/lib/src/elements/object_common.dart (right): https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart#newcode88 runtime/observatory/lib/src/elements/object_common.dart:88: void render() { long line? https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart#newcode172 runtime/observatory/lib/src/elements/object_common.dart:172: content.add( don't ...
4 years, 4 months ago (2016-08-19 22:11:19 UTC) #4
cbernaschina
https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart File runtime/observatory/lib/src/elements/object_common.dart (right): https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart#newcode88 runtime/observatory/lib/src/elements/object_common.dart:88: void render() { On 2016/08/19 22:11:19, Cutch wrote: > ...
4 years, 4 months ago (2016-08-19 22:17:40 UTC) #5
Cutch
https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart File runtime/observatory/lib/src/elements/object_common.dart (right): https://codereview.chromium.org/2265513003/diff/20001/runtime/observatory/lib/src/elements/object_common.dart#newcode88 runtime/observatory/lib/src/elements/object_common.dart:88: void render() { On 2016/08/19 22:17:40, cbernaschina wrote: > ...
4 years, 4 months ago (2016-08-19 22:21:38 UTC) #6
Cutch
LGTM
4 years, 4 months ago (2016-08-20 00:04:19 UTC) #7
cbernaschina
4 years, 4 months ago (2016-08-20 00:07:16 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d272f763d8fdfefaa8fab0fd5fcaf49fe5d082cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698