runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart - Issue 2265513003: Converted Observatory object-common element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart

Issue 2265513003: Converted Observatory object-common element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/object_common/element_test.html ('k') | runtime/observatory/tests/observatory_ui/retaining_path/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart b/runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart

index ec10960829577561f85c8d2f34a3693954c457a8..472df2b5fdf0b3e2f21dcea35e42b0c417b60c5b 100644

--- a/runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart

+++ b/runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart

@@ -10,7 +10,7 @@ import '../mocks.dart';

main() {

SentinelValueElement.tag.ensureRegistration();

- const sentinel = const Sentinel();

+ const sentinel = const SentinelMock();

test('instantiation', () {

final e = new SentinelValueElement(sentinel);

expect(e, isNotNull, reason: 'element correctly created');