Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/platform/testing/TransformPrinters.cpp

Issue 2265453003: Add platform/transforms pretty printers for logging and testing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update per reviewer comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
diff --git a/third_party/WebKit/Source/platform/testing/TransformPrinters.cpp b/third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
index 1707336a4c6b4b5f926786b2dd17045eebe87a88..ba03cc72f72dc3c7a10a986c44f112c28b650b36 100644
--- a/third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
+++ b/third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
@@ -6,52 +6,19 @@
#include "platform/transforms/AffineTransform.h"
#include "platform/transforms/TransformationMatrix.h"
+#include "wtf/text/WTFString.h"
#include <ostream> // NOLINT
namespace blink {
void PrintTo(const AffineTransform& transform, std::ostream* os)
{
- AffineTransform::DecomposedType decomposition;
- if (!transform.decompose(decomposition)) {
- *os << "AffineTransform(degenerate)";
- return;
- }
-
- if (transform.isIdentityOrTranslation()) {
- *os << "AffineTransform(translation=(" << decomposition.translateX << "," << decomposition.translateY << "))";
- return;
- }
-
- *os << "AffineTransform("
- << "translation=(" << decomposition.translateX << "," << decomposition.translateY << ")"
- << ", scale=(" << decomposition.scaleX << "," << decomposition.scaleY << ")"
- << ", angle=(" << decomposition.angle << ")"
- << ", remainder=(" << decomposition.remainderA << "," << decomposition.remainderB << "," << decomposition.remainderC << "," << decomposition.remainderD << ")"
- << ", translate=(" << decomposition.translateX << "," << decomposition.translateY << ")"
- << ")";
+ *os << transform.toString();
}
void PrintTo(const TransformationMatrix& matrix, std::ostream* os)
{
- TransformationMatrix::DecomposedType decomposition;
- if (!matrix.decompose(decomposition)) {
- *os << "TransformationMatrix(degenerate)";
- return;
- }
-
- if (matrix.isIdentityOrTranslation()) {
- *os << "TransformationMatrix(translation=(" << decomposition.translateX << "," << decomposition.translateY << "," << decomposition.translateZ << "))";
- return;
- }
-
- *os << "TransformationMatrix("
- << "translation=(" << decomposition.translateX << "," << decomposition.translateY << "," << decomposition.translateZ << ")"
- << ", scale=(" << decomposition.scaleX << "," << decomposition.scaleY << "," << decomposition.scaleZ << ")"
- << ", skew=(" << decomposition.skewXY << "," << decomposition.skewXZ << "," << decomposition.skewYZ << ")"
- << ", quaternion=(" << decomposition.quaternionX << "," << decomposition.quaternionY << "," << decomposition.quaternionZ << "," << decomposition.quaternionW << ")"
- << ", perspective=(" << decomposition.perspectiveX << "," << decomposition.perspectiveY << "," << decomposition.perspectiveZ << "," << decomposition.perspectiveW << ")"
- << ")";
+ *os << matrix.toString();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698