Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl

Issue 2265363002: [Presentation API] make PresentationReceiver API consistent with latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolve code review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl
index 32226f7e734a4c499d5a63d3a25db6ddc63ad197..5138427750c6c1f9b4d2fd68ba094933244ffda9 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl
+++ b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl
@@ -2,13 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// https://w3c.github.io/presentation-api/#interface-presentation
+// This API was never implemented and has no known functional usages,
+// so this is a no-op as far as Web compatibility is concerned;
+// we should send an intent to ship when the implementation is further along.
mlamouri (slow - plz ping) 2016/08/24 16:48:59 I don't think you need this comment.
zhaobin 2016/08/24 17:34:12 Done.
+
+// https://w3c.github.io/presentation-api/#idl-def-presentationreceiver
[
RuntimeEnabled=PresentationReceiver
-] interface PresentationReceiver : EventTarget {
- [CallWith=ScriptState] Promise<PresentationConnection> getConnection();
- [CallWith=ScriptState] Promise<sequence<PresentationConnection>> getConnections();
-
- attribute EventHandler onconnectionavailable;
+] interface PresentationReceiver {
+ [SameObject, CallWith=ScriptState] readonly attribute Promise<PresentationConnectionList> connectionList;
};

Powered by Google App Engine
This is Rietveld 408576698