third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl - Issue 2265363002: [Presentation API] make PresentationReceiver API consistent with latest spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl

Issue 2265363002: [Presentation API] make PresentationReceiver API consistent with latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve code review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp ('K') | « third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/presentation-api/#interface-presentation	5 // This API was never implemented and has no known functional usages,

	6 // so this is a no-op as far as Web compatibility is concerned;

	7 // we should send an intent to ship when the implementation is further along.
	mlamouri (slow - plz ping) 2016/08/24 16:48:59 I don't think you need this comment. I don't think you need this comment. zhaobin 2016/08/24 17:34:12 Done. Show quoted text On 2016/08/24 16:48:59, mlamouri (slow) wrote: > I don't think you need this comment. Done.
	8

	9 // https://w3c.github.io/presentation-api/#idl-def-presentationreceiver

6	10

7 [	11 [

8 RuntimeEnabled=PresentationReceiver	12 RuntimeEnabled=PresentationReceiver

9 ] interface PresentationReceiver : EventTarget {	13 ] interface PresentationReceiver {

10 [CallWith=ScriptState] Promise<PresentationConnection> getConnection();	14 [SameObject, CallWith=ScriptState] readonly attribute Promise<PresentationCo nnectionList> connectionList;

11 [CallWith=ScriptState] Promise<sequence<PresentationConnection>> getConnecti ons();

12

13 attribute EventHandler onconnectionavailable;

14 };	15 };

OLD	NEW