Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2265323002: Remove virtual from overrides in SkGpuDevice.h (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robetphillips, robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@gpuarc
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M src/gpu/SkGpuDevice.h View 1 chunk +27 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
bsalomon
Returns some newlines to the global pool.
4 years, 4 months ago (2016-08-22 20:06:26 UTC) #3
robertphillips
lgtm
4 years, 4 months ago (2016-08-22 21:18:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265323002/1
4 years, 4 months ago (2016-08-22 21:24:33 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:48:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dcb406c29d72842684e67e746ddf7fe0b9a597db

Powered by Google App Engine
This is Rietveld 408576698