GPU implementation of drawArc.

GPU implementation of drawArc.

This adds analytic shaders for filled arcs and butt-cap stroked arcs where the center point is not used.

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003

Committed: https://skia.googlesource.com/skia/+/4f3a0ca85d28a8fc7fcc1ac5c4a1864c66bdea14

[bsalomon, 2016-08-19 21:03:16]

Description was changed from

==========
GPU implementation of drawArc, fill only

BUG=skia:5227
==========

to

==========
GPU implementation of drawArc, fill only

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003
==========

[bsalomon, 2016-08-20 16:40:31]

Patchset #2 (id:20001) has been deleted

[bsalomon, 2016-08-22 16:41:32]

Description was changed from

==========
GPU implementation of drawArc, fill only

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003
==========

to

==========
GPU implementation of drawArc.

This adds analytic shaders for filled arcs and butt-cap stroked arcs where the
center point is not used.

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003
==========

[bsalomon, 2016-08-22 16:41:32]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2016-08-22 19:02:52]

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:668: batch->fClipPlane = true;
space before '>' ?

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:676: {norm1.fX, norm1.fY, 0.5f},
I'm not sure if it would be clearer to create a single devProxyRect and use it
everywhere. Your call.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:738: radius += halfWidth;
Are these bounds correct? It seems like we should use outerRadius.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:887: 
// Because we've set up the batches that don't use the planes with noop values
we can just
// accumulate used planes by later batches 

?

[bsalomon, 2016-08-22 19:18:27]

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:668: batch->fClipPlane = true;
On 2016/08/22 19:02:52, robertphillips wrote:
> space before '>' ?

Done.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:676: {norm1.fX, norm1.fY, 0.5f},
On 2016/08/22 19:02:52, robertphillips wrote:
> I'm not sure if it would be clearer to create a single devProxyRect and use it
> everywhere. Your call.

Done.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:738: radius += halfWidth;
On 2016/08/22 19:02:52, robertphillips wrote:
> Are these bounds correct? It seems like we should use outerRadius.

See comment above, using original values since the bounds aren't supposed to
include aa bloat.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:887: 
On 2016/08/22 19:02:52, robertphillips wrote:
> // Because we've set up the batches that don't use the planes with noop values
> we can just
> // accumulate used planes by later batches 
> 
> ?

Done.

[robertphillips, 2016-08-22 19:43:34]

other than possible batch-bound issue, lgtm.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:591: case SkStrokeRec::kStrokeAndFill_Style:
results -> result ?

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:596: break;
// fall through ?

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/SkGpuDevice.h#...
src/gpu/SkGpuDevice.h:79: const SkPaint& paint) override;
rm virtual ?

[bsalomon, 2016-08-22 19:46:40]

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:591: case SkStrokeRec::kStrokeAndFill_Style:
On 2016/08/22 19:43:34, robertphillips wrote:
> results -> result ?

Done.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/GrOvalRenderer...
src/gpu/GrOvalRenderer.cpp:596: break;
On 2016/08/22 19:43:34, robertphillips wrote:
> // fall through ?

Done.

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/2259323003/diff/160001/src/gpu/SkGpuDevice.h#...
src/gpu/SkGpuDevice.h:79: const SkPaint& paint) override;
On 2016/08/22 19:43:34, robertphillips wrote:
> rm virtual ?

I'll land as is and then do a build removal.

[bsalomon, 2016-08-22 19:46:44]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-08-22 19:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2259323003/#ps200001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-22 19:46:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 20:14:29]

Description was changed from

==========
GPU implementation of drawArc.

This adds analytic shaders for filled arcs and butt-cap stroked arcs where the
center point is not used.

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003
==========

to

==========
GPU implementation of drawArc.

This adds analytic shaders for filled arcs and butt-cap stroked arcs where the
center point is not used.

BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259323003

Committed:
https://skia.googlesource.com/skia/+/4f3a0ca85d28a8fc7fcc1ac5c4a1864c66bdea14
==========

[commit-bot: I haz the power, 2016-08-22 20:14:30]

Committed patchset #10 (id:200001) as
https://skia.googlesource.com/skia/+/4f3a0ca85d28a8fc7fcc1ac5c4a1864c66bdea14