Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issue 226523006: Changes to content/ to facilitate new zoom extension API (work in progress) (Closed)

Created:
6 years, 8 months ago by paulmeyer
Modified:
6 years, 6 months ago
Reviewers:
Fady Samuel, wjmaclean, jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, miu+watch_chromium.org, wjmaclean
Visibility:
Public.

Description

Some minimal changes to content/ needed to facilitate the new zoom extension API, which is outlined in: https://docs.google.com/a/chromium.org/document/d/1sCZjx1J3_M2a02T8NXd-ufGKZDoBHI5Ixis1DaGLQCA/edit?usp=sharing. BUG=30583

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -50 lines) Patch
M content/browser/host_zoom_map_impl.h View 2 chunks +13 lines, -9 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 7 chunks +39 lines, -33 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M content/common/view_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/host_zoom_map.h View 1 chunk +16 lines, -1 line 1 comment Download
M content/public/browser/web_contents.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
paulmeyer
6 years, 8 months ago (2014-04-12 03:57:18 UTC) #1
Avi (use Gerrit)
John likes looking at content/public.
6 years, 8 months ago (2014-04-12 04:06:48 UTC) #2
jam
just a small comment can i see the chrome calling code somewhere? https://codereview.chromium.org/226523006/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc ...
6 years, 7 months ago (2014-05-01 23:21:12 UTC) #3
wjmaclean
On 2014/05/01 23:21:12, jam wrote: > just a small comment > > can i see ...
6 years, 7 months ago (2014-05-02 16:14:40 UTC) #4
jam
On 2014/05/02 16:14:40, wjmaclean wrote: > On 2014/05/01 23:21:12, jam wrote: > > just a ...
6 years, 7 months ago (2014-05-02 19:15:04 UTC) #5
wjmaclean
On 2014/05/02 19:15:04, jam wrote: > On 2014/05/02 16:14:40, wjmaclean wrote: > > On 2014/05/01 ...
6 years, 7 months ago (2014-05-08 18:40:48 UTC) #6
jam
On 2014/05/08 18:40:48, wjmaclean wrote: > On 2014/05/02 19:15:04, jam wrote: > > On 2014/05/02 ...
6 years, 7 months ago (2014-05-09 17:09:55 UTC) #7
wjmaclean
6 years, 6 months ago (2014-05-28 15:31:52 UTC) #8
Message was sent while issue was closed.
Moved to https://codereview.chromium.org/302603012/

Powered by Google App Engine
This is Rietveld 408576698