Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 2265093002: clang plugin: Remove follow-macro-expansion toggle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "FindBadConstructsAction.h" 5 #include "FindBadConstructsAction.h"
6 6
7 #include "clang/AST/ASTConsumer.h" 7 #include "clang/AST/ASTConsumer.h"
8 #include "clang/Frontend/FrontendPluginRegistry.h" 8 #include "clang/Frontend/FrontendPluginRegistry.h"
9 9
10 #include "FindBadConstructsConsumer.h" 10 #include "FindBadConstructsConsumer.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 options_.enforce_in_pdf = true; 51 options_.enforce_in_pdf = true;
52 } else if (args[i] == "enforce-in-thirdparty-webkit") { 52 } else if (args[i] == "enforce-in-thirdparty-webkit") {
53 options_.enforce_in_thirdparty_webkit = true; 53 options_.enforce_in_thirdparty_webkit = true;
54 } else if (args[i] == "check-enum-last-value") { 54 } else if (args[i] == "check-enum-last-value") {
55 // TODO(tsepez): Enable this by default once http://crbug.com/356815 55 // TODO(tsepez): Enable this by default once http://crbug.com/356815
56 // and http://crbug.com/356816 are fixed. 56 // and http://crbug.com/356816 are fixed.
57 options_.check_enum_last_value = true; 57 options_.check_enum_last_value = true;
58 } else if (args[i] == "check-templates") { 58 } else if (args[i] == "check-templates") {
59 options_.check_templates = true; 59 options_.check_templates = true;
60 } else if (args[i] == "follow-macro-expansion") { 60 } else if (args[i] == "follow-macro-expansion") {
61 options_.follow_macro_expansion = true; 61 // TODO(thakis): This is now always on. Remove support for this flag once
62 // the build no longer passes it in.
62 } else if (args[i] == "no-realpath") { 63 } else if (args[i] == "no-realpath") {
63 options_.no_realpath = true; 64 options_.no_realpath = true;
64 } else if (args[i] == "check-ipc") { 65 } else if (args[i] == "check-ipc") {
65 options_.check_ipc = true; 66 options_.check_ipc = true;
66 } else if (args[i] == "check-auto-raw-pointer") { 67 } else if (args[i] == "check-auto-raw-pointer") {
67 options_.check_auto_raw_pointer = true; 68 options_.check_auto_raw_pointer = true;
68 } else if (args[i] == "check-implicit-copy-ctors") { 69 } else if (args[i] == "check-implicit-copy-ctors") {
69 // This is deprecated and will be removed once the flag is not used. 70 // This is deprecated and will be removed once the flag is not used.
70 } else { 71 } else {
71 parsed = false; 72 parsed = false;
72 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n"; 73 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
73 } 74 }
74 } 75 }
75 76
76 return parsed; 77 return parsed;
77 } 78 }
78 79
79 } // namespace chrome_checker 80 } // namespace chrome_checker
80 81
81 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X( 82 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
82 "find-bad-constructs", 83 "find-bad-constructs",
83 "Finds bad C++ constructs"); 84 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698