Handle unicode correctly in CallPrinter

Handle unicode correctly in CallPrinter

CallPrinter currently has only a single use, namely to print the call
site when throwing CalledNonCallable (ConstructedNonConstructable)
errors. This ensures that unicode call sites such as "あいう"() are
printed correctly by using an IncrementalStringBuilder internally.

BUG=637167
Committed: https://crrev.com/a89639e79c77c2276fb20f150a7bdddcf6d572d6
Cr-Commit-Position: refs/heads/master@{#38790}

[jgruber, 2016-08-22 13:37:05]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 13:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-22 13:46:45]

jgruber@chromium.org changed reviewers:
+ verwaest@chromium.org

[jgruber, 2016-08-22 13:46:45]

An alternative solution would be to get rid of CallPrinter entirely, and print
the source slice 

[FoundAstNode.position, successor(FoundAstNode).position]

instead. We'd lose things such as eliding arguments (f(42)() -> 'f(...) is not a
function') and whitespace normalization though.

[Toon Verwaest, 2016-08-22 14:23:12]

lgtm with comment

https://codereview.chromium.org/2265073002/diff/1/src/ast/prettyprinter.cc
File src/ast/prettyprinter.cc (right):

https://codereview.chromium.org/2265073002/diff/1/src/ast/prettyprinter.cc#ne...
src/ast/prettyprinter.cc:405: void CallPrinter::PrintLiteral(Object* value, bool
quote) {
Pass in Handle<Object> value rather than Object*

[jgruber, 2016-08-22 14:43:25]

https://codereview.chromium.org/2265073002/diff/1/src/ast/prettyprinter.cc
File src/ast/prettyprinter.cc (right):

https://codereview.chromium.org/2265073002/diff/1/src/ast/prettyprinter.cc#ne...
src/ast/prettyprinter.cc:405: void CallPrinter::PrintLiteral(Object* value, bool
quote) {
On 2016/08/22 14:23:12, Toon Verwaest wrote:
> Pass in Handle<Object> value rather than Object*

Done.

[jgruber, 2016-08-22 14:43:29]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-08-22 14:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2265073002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-22 14:46:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 15:13:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 15:13:21]

Description was changed from

==========
Handle unicode correctly in CallPrinter

CallPrinter currently has only a single use, namely to print the call
site when throwing CalledNonCallable (ConstructedNonConstructable)
errors. This ensures that unicode call sites such as "あいう"() are
printed correctly by using an IncrementalStringBuilder internally.

BUG=637167
==========

to

==========
Handle unicode correctly in CallPrinter

CallPrinter currently has only a single use, namely to print the call
site when throwing CalledNonCallable (ConstructedNonConstructable)
errors. This ensures that unicode call sites such as "あいう"() are
printed correctly by using an IncrementalStringBuilder internally.

BUG=637167

Committed: https://crrev.com/a89639e79c77c2276fb20f150a7bdddcf6d572d6
Cr-Commit-Position: refs/heads/master@{#38790}
==========

[commit-bot: I haz the power, 2016-08-22 15:13:22]

Patchset 2 (id:??) landed as
https://crrev.com/a89639e79c77c2276fb20f150a7bdddcf6d572d6
Cr-Commit-Position: refs/heads/master@{#38790}