Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: src/runtime/runtime-internal.cc

Issue 2265073002: Handle unicode correctly in CallPrinter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-internal.cc
diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc
index a295190f0dc02a26690c6b6a880d49852108b5ee..3de0f16b1e63233ca72bdb4ab8fa311e3d9653b5 100644
--- a/src/runtime/runtime-internal.cc
+++ b/src/runtime/runtime-internal.cc
@@ -411,10 +411,8 @@ Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) {
: new ParseInfo(&zone, location.script()));
if (Parser::ParseStatic(info.get())) {
CallPrinter printer(isolate, location.function()->shared()->IsBuiltin());
- const char* string = printer.Print(info->literal(), location.start_pos());
- if (strlen(string) > 0) {
- return isolate->factory()->NewStringFromAsciiChecked(string);
- }
+ Handle<String> str = printer.Print(info->literal(), location.start_pos());
+ if (str->length() > 0) return str;
} else {
isolate->clear_pending_exception();
}
« no previous file with comments | « src/ast/prettyprinter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698