Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2265043002: MIPS: [stubs,interpreter] Optimise SMI loading for 64-bit targets. (Closed)

Created:
4 years, 4 months ago by miran.karic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [stubs,interpreter] Optimise SMI loading for 64-bit targets. Port 28e3467a72755b05ff5f6c9996955f5eb10e3971 (r38361) original commit message: Adding new methods to the code stub assembler and interpreter assembler to combine loading and untagging SMIs, so that on 64-bit architectures we can avoid loading the full 64 bits and load the 32 interesting bits directly instead. BUG= Committed: https://crrev.com/239f9816531a7e96c7f144b0bc5f38ce18ef2889 Cr-Commit-Position: refs/heads/master@{#38811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -18 lines) Patch
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +48 lines, -18 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
miran.karic
4 years, 4 months ago (2016-08-22 13:09:10 UTC) #2
ivica.bogosavljevic
On 2016/08/22 13:09:10, miran.karic wrote: lgtm
4 years, 4 months ago (2016-08-22 13:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265043002/1
4 years, 4 months ago (2016-08-22 13:38:43 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-22 13:38:45 UTC) #7
akos.palfi.imgtec
lgtm
4 years, 4 months ago (2016-08-22 13:45:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265043002/1
4 years, 4 months ago (2016-08-23 09:14:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 09:35:32 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 09:36:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/239f9816531a7e96c7f144b0bc5f38ce18ef2889
Cr-Commit-Position: refs/heads/master@{#38811}

Powered by Google App Engine
This is Rietveld 408576698