chrome/browser/browser_resources.grd - Issue 2264983002: MD History: Lazily load element files which are not needed for first paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_resources.grd

Issue 2264983002: MD History: Lazily load element files which are not needed for first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: calamity@ review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_resources.grd

diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd

index b29c5859e5fb4bff4c630e6a98cbc251a131ed7e..5727436b088f2ad52067c3230f3b4b3f82f829ab 100644

--- a/chrome/browser/browser_resources.grd

+++ b/chrome/browser/browser_resources.grd

@@ -239,6 +239,8 @@

<then>

+ <include name="IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML" file="resources\md_history\lazy_load.vulcanized.html" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

Dan Beam 2016/09/22 04:42:06 why do you need flattenhtml="true"?

tsergeant 2016/09/23 01:19:51 Hmmm, no reason. I've removed it from all the new

+ <include name="IDR_MD_HISTORY_LAZY_LOAD_CRISPER_JS" file="resources\md_history\lazy_load.crisper.js" flattenhtml="true" allowexternalscript="true" type="BINDATA" />

</then>

<else>

@@ -256,6 +258,7 @@

+ <include name="IDR_MD_HISTORY_LAZY_LOAD_HTML" file="resources\md_history\lazy_load.html" flattenhtml="true" type="BINDATA" />

« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | no next file with comments »