chrome/browser/net/chrome_extensions_network_delegate.h - Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_extensions_network_delegate.h

Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: fix while loop Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/net/chrome_extensions_network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_extensions_network_delegate.h

diff --git a/chrome/browser/net/chrome_extensions_network_delegate.h b/chrome/browser/net/chrome_extensions_network_delegate.h

index a8066a9618f66358c202c4bab1d110c2d373e2b1..0645e052cad22fd822053c50a91f0cf6e207daf7 100644

--- a/chrome/browser/net/chrome_extensions_network_delegate.h

+++ b/chrome/browser/net/chrome_extensions_network_delegate.h

@@ -36,7 +36,7 @@ class ChromeExtensionsNetworkDelegate : public net::NetworkDelegateImpl {

// If the |request| failed due to problems with a proxy, forward the error to

// the proxy extension API.

- virtual void ForwardProxyErrors(net::URLRequest* request);

+ virtual void ForwardProxyErrors(net::URLRequest* request, int net_error);

// Notifies the extensions::ProcessManager for the associated RenderFrame, if

// any, that a request has started or stopped.

@@ -60,8 +60,10 @@ class ChromeExtensionsNetworkDelegate : public net::NetworkDelegateImpl {

GURL* allowed_unsafe_redirect_url) override;

void OnBeforeRedirect(net::URLRequest* request,

const GURL& new_location) override;

- void OnResponseStarted(net::URLRequest* request) override;

- void OnCompleted(net::URLRequest* request, bool started) override;

+ void OnResponseStarted(net::URLRequest* request, int net_error) override;

+ void OnCompleted(net::URLRequest* request,

+ bool started,

+ int net_error) override;

void OnURLRequestDestroyed(net::URLRequest* request) override;

void OnPACScriptError(int line_number, const base::string16& error) override;

net::NetworkDelegate::AuthRequiredResponse OnAuthRequired(