chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc - Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: fix while loop Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_protocols_unittest.cc ('k') | chrome/browser/net/chrome_extensions_network_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

diff --git a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

index 97cb50e63cb009c469b17f04e21d99a5de1ca62e..02480b84f44502edc679fac0ee148b081a7a9490 100644

--- a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

+++ b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

@@ -793,14 +793,16 @@ void ChromeResourceDispatcherHostDelegate::RequestComplete(

net::URLRequest* url_request) {

if (!url_request)

return;

+ // TODO(maksims): remove this and use net_error argument in RequestComplete

+ // once ResourceDispatcherHostDelegate is modified.

+ int net_error = url_request->status().error();

const ResourceRequestInfo* info =

ResourceRequestInfo::ForRequest(url_request);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(&NotifyUIThreadOfRequestComplete,

info->GetWebContentsGetterForRequest(), url_request->url(),

- info->GetResourceType(), url_request->was_cached(),

- url_request->status().error(),

+ info->GetResourceType(), url_request->was_cached(), net_error,

url_request->GetTotalReceivedBytes(),

base::TimeTicks::Now() - url_request->creation_time()));

}