Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
index 35f8e56db2e4e6c326a11b313988088a30819a65..d550661dc30458bc1b9b81304b9b1b98359c68e3 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
@@ -101,8 +101,9 @@ class TestURLRequestDelegate : public net::URLRequest::Delegate {
: read_completed_callback_(callback),
buffer_(new net::IOBuffer(kBufSize)) {}
- void OnResponseStarted(net::URLRequest* request) override {
- if (!request->status().is_success()) {
+ void OnResponseStarted(net::URLRequest* request, int net_error) override {
+ DCHECK_NE(net::ERR_IO_PENDING, net_error);
dewittj 2016/09/22 16:27:06 This DCHECK seems wrong. I can see two cases here
maksims (do not use this acc) 2016/09/29 12:43:14 Actually, IO_PENDING must not arrive here. It's ju
+ if (net_error != net::OK) {
read_completed_callback_.Run(0);
return;
}

Powered by Google App Engine
This is Rietveld 408576698