Adjust callers and networking delegates in chrome/ to modified APIs

chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
 
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
@@ skipping 83 matching lines @@
 };
 
 class TestURLRequestDelegate : public net::URLRequest::Delegate {
  public:
   typedef base::Callback<void(int)> ReadCompletedCallback;
 
   explicit TestURLRequestDelegate(const ReadCompletedCallback& callback)
       : read_completed_callback_(callback),
         buffer_(new net::IOBuffer(kBufSize)) {}
 
-  void OnResponseStarted(net::URLRequest* request) override {
-    if (!request->status().is_success()) {
+  void OnResponseStarted(net::URLRequest* request, int net_error) override {
+    DCHECK_NE(net::ERR_IO_PENDING, net_error);

[dewittj, 2016/09/22 16:27:06]

This DCHECK seems wrong.  I can see two cases here:
* I'm likely to get an IO_PENDING message for normal usage.  In that case we
should just return early.
* I'm not likely to get an IO_PENDING message; then the net::OK check seems
fine.

Neither case should require a DCHECK, right?

[maksims (do not use this acc), 2016/09/29 12:43:14]

Actually, IO_PENDING must not arrive here. It's just a check.

+    if (net_error != net::OK) {
       read_completed_callback_.Run(0);
       return;
     }
     int bytes_read = 0;
     request->Read(buffer_.get(), kBufSize, &bytes_read);
   }
 
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override {
     if (!read_completed_callback_.is_null())
       read_completed_callback_.Run(bytes_read);
@@ skipping 640 matching lines @@
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
   EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_CONNECTED_NETWORK);
 }
 
 }  // namespace offline_pages