Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22649003: Have the Performance interface inherit EventTarget (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, lgombos
Visibility:
Public.

Description

Have the Performance interface inherit EventTarget Have the Performance interface inherit EventTarget so that developers can listen for the resourcetimingbufferfull event using addEventListener() and to match the latest specification: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/ResourceTiming/Overview.html#extensions-performance-interface Corresponding discussion: http://lists.w3.org/Archives/Public/public-web-perf/2013Jul/0004.html http://lists.w3.org/Archives/Public/public-web-perf/2013Aug/0017.html Also remove hack from the bindings generator as Performance was the only interface with an EventHandler attribute which did not inherit from EventTarget. BUG=269927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155875

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use window.onload #

Patch Set 3 : Rebaseline additional w3c test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -20 lines) Patch
M LayoutTests/fast/dom/Window/window-properties-performance-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/webtiming-buffer-full-no-event-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/idlharness-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 2 chunks +1 line, -12 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 4 chunks +8 lines, -2 lines 0 comments Download
M Source/core/page/Performance.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
do-not-use
The new presubmit check for the bindings test caught me :) Thanks Nils, very useful.
7 years, 4 months ago (2013-08-08 07:15:26 UTC) #1
haraken
LGTM. Needs an approval from an API reviewer. https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html File LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html (right): https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html#newcode31 LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html:31: finishJSTest(); ...
7 years, 4 months ago (2013-08-08 07:29:09 UTC) #2
do-not-use
https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html File LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html (right): https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html#newcode31 LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html:31: finishJSTest(); On 2013/08/08 07:29:09, haraken wrote: > > Nit: ...
7 years, 4 months ago (2013-08-08 07:37:26 UTC) #3
haraken
On 2013/08/08 07:37:26, Christophe Dumez wrote: > https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html > File LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html (right): > > https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html#newcode31 ...
7 years, 4 months ago (2013-08-08 07:40:15 UTC) #4
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html File LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html (right): https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html#newcode25 LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html:25: <body onload="test()"> Or: window.onload = test; https://codereview.chromium.org/22649003/diff/1/LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html#newcode31 LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html:31: ...
7 years, 4 months ago (2013-08-08 14:31:01 UTC) #5
do-not-use
I will investigate more but if I don't make the test async, then the output ...
7 years, 4 months ago (2013-08-08 18:02:39 UTC) #6
tkent
lgtm
7 years, 4 months ago (2013-08-08 22:46:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22649003/10001
7 years, 4 months ago (2013-08-09 06:08:51 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on win_blink_rel HTTP Error 400: Bad Request
7 years, 4 months ago (2013-08-09 18:08:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22649003/23001
7 years, 4 months ago (2013-08-09 18:09:09 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 22:03:00 UTC) #11
Message was sent while issue was closed. 
Change committed as 155875

Powered by Google App Engine
This is Rietveld 408576698