LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html - Issue 22649003: Have the Performance interface inherit EventTarget

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/misc/webtiming-buffer-full-no-event.html

Issue 22649003: Have the Performance interface inherit EventTarget (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/Window/window-properties-performance-expected.txt ('k') | LayoutTests/http/tests/misc/webtiming-buffer-full-no-event-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <link rel="help" href="https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/Resourc eTiming/Overview.html#extensions-performance-interface">

	4 <script src="../resources/js-test-pre.js"></script>

	5 <script>

	6 description("This test checks that Performance inherits EventTarget and that add EventListener() works for resourcetimingbufferfull events.");

	7 window.jsTestIsAsync = true;

	8 var bufferFullCount = 0;

	9 var parameter;

	10

	11 function onBufferFull(event) {

	12 parameter = event;

	13 shouldBe('parameter.__proto__', 'Event.prototype');

	14 bufferFullCount++;

	15 }

	16

	17 shouldBe('Performance.prototype.__proto__', 'EventTarget.prototype');

	18

	19 performance.webkitSetResourceTimingBufferSize(2);

	20 shouldBeNull('performance.onwebkitresourcetimingbufferfull');

	21 performance.addEventListener('webkitresourcetimingbufferfull', onBufferFull);

	22 shouldBeNull('performance.onwebkitresourcetimingbufferfull');

	23 </script>

	24 </head>

	25 <body onload="test()">
	arv (Not doing code reviews) 2013/08/08 14:31:01 Or: window.onload = test; Or: window.onload = test;
	26 <script>

	27 function test() {

	28 // Make sure the onBufferFull callback was called exactly 1 time.

	29 shouldBe('bufferFullCount', '1');

	30 performance.removeEventListener('webkitresourcetimingbufferfull', onBufferFu ll);

	31 finishJSTest();
	haraken 2013/08/08 07:29:09 Nit: Why do you need to make the test asynchronous Nit: Why do you need to make the test asynchronous? do-not-use 2013/08/08 07:37:27 I need to complete the test after the onload handl Show quoted text On 2013/08/08 07:29:09, haraken wrote: > > Nit: Why do you need to make the test asynchronous? I need to complete the test after the onload handler has been executed or the onBufferFull() callback will not have been called yet when the test completes. arv (Not doing code reviews) 2013/08/08 14:31:01 I don't think you need an async test here. js-test Show quoted text On 2013/08/08 07:37:27, Christophe Dumez wrote: > On 2013/08/08 07:29:09, haraken wrote: > > > > Nit: Why do you need to make the test asynchronous? > > I need to complete the test after the onload handler has been executed or the > onBufferFull() callback will not have been called yet when the test completes. I don't think you need an async test here. js-test-* waits until after window.onload.
	32 }

	33 </script>

	34 <script src="../resources/js-test-post.js"></script>

	35 </body>

	36 </html>

OLD	NEW