Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2264873002: Revert "Add new feature flag to enable background loader for downloads" (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
Reviewers:
chili
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add new feature flag to enable background loader for downloads" This reverts commit 936aa9ea40216e8f196671817773450235a1fe4f. Highly speculative revert for https://crbug.com/639618. If this doesn't make things more green I'll reland, in which case I apologize for the noise. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639618 TBR=chili@chromium.org Committed: https://crrev.com/49a0965d306375f84d25cc1c208339de7c5e3a57 Cr-Commit-Position: refs/heads/master@{#413349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_feature.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/offline_pages/offline_page_feature.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264873002/1
4 years, 4 months ago (2016-08-20 20:24:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 20:25:14 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 20:27:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49a0965d306375f84d25cc1c208339de7c5e3a57
Cr-Commit-Position: refs/heads/master@{#413349}

Powered by Google App Engine
This is Rietveld 408576698