Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: components/offline_pages/offline_page_feature.cc

Issue 2264873002: Revert "Add new feature flag to enable background loader for downloads" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/offline_page_feature.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_feature.h" 5 #include "components/offline_pages/offline_page_feature.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/feature_list.h" 9 #include "base/feature_list.h"
10 10
(...skipping 11 matching lines...) Expand all
22 "OfflinePagesBackgroundLoading", base::FEATURE_DISABLED_BY_DEFAULT 22 "OfflinePagesBackgroundLoading", base::FEATURE_DISABLED_BY_DEFAULT
23 }; 23 };
24 24
25 const base::Feature kOfflinePagesCTFeature { 25 const base::Feature kOfflinePagesCTFeature {
26 "OfflinePagesCT", base::FEATURE_DISABLED_BY_DEFAULT 26 "OfflinePagesCT", base::FEATURE_DISABLED_BY_DEFAULT
27 }; 27 };
28 28
29 const base::Feature kOfflinePagesSharingFeature{ 29 const base::Feature kOfflinePagesSharingFeature{
30 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT}; 30 "OfflinePagesSharing", base::FEATURE_DISABLED_BY_DEFAULT};
31 31
32 const base::Feature kBackgroundLoaderForDownloadsFeature{
33 "BackgroundLoadingForDownloads", base::FEATURE_ENABLED_BY_DEFAULT};
34
35 bool IsOfflinePagesEnabled() { 32 bool IsOfflinePagesEnabled() {
36 return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() || 33 return IsOfflineBookmarksEnabled() || IsOffliningRecentPagesEnabled() ||
37 IsOfflinePagesBackgroundLoadingEnabled() || 34 IsOfflinePagesBackgroundLoadingEnabled() ||
38 IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled() || 35 IsOfflinePagesCTEnabled() || IsOfflinePagesSharingEnabled();
39 IsBackgroundLoaderForDownloadsEnabled();
40 } 36 }
41 37
42 bool IsOfflineBookmarksEnabled() { 38 bool IsOfflineBookmarksEnabled() {
43 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature); 39 return base::FeatureList::IsEnabled(kOfflineBookmarksFeature);
44 } 40 }
45 41
46 bool IsOffliningRecentPagesEnabled() { 42 bool IsOffliningRecentPagesEnabled() {
47 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature); 43 return base::FeatureList::IsEnabled(kOffliningRecentPagesFeature);
48 } 44 }
49 45
50 bool IsOfflinePagesBackgroundLoadingEnabled() { 46 bool IsOfflinePagesBackgroundLoadingEnabled() {
51 return base::FeatureList::IsEnabled(kOfflinePagesBackgroundLoadingFeature); 47 return base::FeatureList::IsEnabled(kOfflinePagesBackgroundLoadingFeature);
52 } 48 }
53 49
54 bool IsOfflinePagesCTEnabled() { 50 bool IsOfflinePagesCTEnabled() {
55 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature); 51 return base::FeatureList::IsEnabled(kOfflinePagesCTFeature);
56 } 52 }
57 53
58 bool IsOfflinePagesSharingEnabled() { 54 bool IsOfflinePagesSharingEnabled() {
59 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature); 55 return base::FeatureList::IsEnabled(kOfflinePagesSharingFeature);
60 } 56 }
61 57
62 bool IsBackgroundLoaderForDownloadsEnabled() {
63 return base::FeatureList::IsEnabled(kBackgroundLoaderForDownloadsFeature);
64 }
65
66 } // namespace offline_pages 58 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_feature.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698