Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2264643002: Added SkColor4f::FromColor3f(SkColor3f, float a) (Closed)

Created:
4 years, 4 months ago by dvonbeck
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Added SkColor4f::FromColor3f(SkColor3f, float a) Planning to use this for the ColorDisplay widget in https://codereview.chromium.org/2259183003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264643002 Committed: https://skia.googlesource.com/skia/+/af0f6efa3502f03b52747f0ede5399e075dbfe5d

Patch Set 1 #

Patch Set 2 : Removed header include from .cpp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M include/core/SkColor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkColor.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dvonbeck
4 years, 4 months ago (2016-08-19 16:00:00 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-08-19 17:51:01 UTC) #6
dvonbeck
4 years, 4 months ago (2016-08-19 17:56:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264643002/20001
4 years, 4 months ago (2016-08-19 17:56:22 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 18:23:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/af0f6efa3502f03b52747f0ede5399e075dbfe5d

Powered by Google App Engine
This is Rietveld 408576698