[Android] Add spellchecking support in android_webview.

[Android] Add spellchecking support in android_webview.

Add spellcheck functionality to webview. Spellchecking
feature will be enabled if the kEnableAndroidSpellChecker
flag is present.

Historical note:
Blink used to have unified_textchecker_enabled setting
which was false by default in android webview and
needed to be enabled in order for spellchecking to work.
It was recently removed in
https://codereview.chromium.org/2235643002/ though.

BUG=583616, 629609
Committed: https://crrev.com/469d6f7b21d83880658cef21112fa20841a4af1b
Cr-Commit-Position: refs/heads/master@{#414331}

[timvolodine, 2016-08-19 15:05:10]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 15:05:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 17:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:14:01]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-08-19 18:21:29]

timvolodine@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[timvolodine, 2016-08-19 18:21:30]

please take a look!

[Tobias Sargeant, 2016-08-23 14:17:58]

It seems some includes are guarded by ENABLE_SPELLCHECK and some are not. is
that intentional? Also, do the gn changes need to be conditional on
enable_spellcheck?

https://codereview.chromium.org/2264633002/diff/1/android_webview/lib/main/aw...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/2264633002/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:144:
cl->AppendSwitch(spellcheck::switches::kEnableAndroidSpellChecker);
I don't think we want to unilaterally enable this initially - I thought the plan
was to set it manually in /data/local/tmp/webview-command-line for testing?

Also, when this flag is enabled, don't we also need to enable the unified editor
flag?

https://codereview.chromium.org/2264633002/diff/1/android_webview/renderer/aw...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/2264633002/diff/1/android_webview/renderer/aw...
android_webview/renderer/aw_content_renderer_client.cc:85: spellcheck_.reset(new
SpellCheck());
base::MakeUnique<SpellCheck>()

[timvolodine, 2016-08-23 15:25:02]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 15:25:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-23 15:29:19]

> It seems some includes are guarded by ENABLE_SPELLCHECK and some are not. is
> that intentional? Also, do the gn changes need to be conditional on
> enable_spellcheck?

Thanks for the comments! Added #if defined(ENABLE_SPELLCHECK) guards and added
enable_spellcheck conditionals to gn files.

https://codereview.chromium.org/2264633002/diff/1/android_webview/lib/main/aw...
File android_webview/lib/main/aw_main_delegate.cc (right):

https://codereview.chromium.org/2264633002/diff/1/android_webview/lib/main/aw...
android_webview/lib/main/aw_main_delegate.cc:144:
cl->AppendSwitch(spellcheck::switches::kEnableAndroidSpellChecker);
On 2016/08/23 14:17:58, Tobias Sargeant wrote:
> I don't think we want to unilaterally enable this initially - I thought the
plan
> was to set it manually in /data/local/tmp/webview-command-line for testing?
> 
> Also, when this flag is enabled, don't we also need to enable the unified
editor
> flag?

right sorry forgot to remove this after testing locally. The unified_editor flag
was removed recently in https://codereview.chromium.org/2235643002/, see the
discussion there. 

Although the unified_editor used to be false by default in webview this probably
shouldn't be an issue if we want to enable spellcheck in webview by default
anyway.

https://codereview.chromium.org/2264633002/diff/1/android_webview/renderer/aw...
File android_webview/renderer/aw_content_renderer_client.cc (right):

https://codereview.chromium.org/2264633002/diff/1/android_webview/renderer/aw...
android_webview/renderer/aw_content_renderer_client.cc:85: spellcheck_.reset(new
SpellCheck());
On 2016/08/23 14:17:58, Tobias Sargeant wrote:
> base::MakeUnique<SpellCheck>()

Done.

[commit-bot: I haz the power, 2016-08-23 17:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:40:20]

Dry run: This issue passed the CQ dry run.

[Tobias Sargeant, 2016-08-24 12:49:46]

LGTM. Thanks.

[Torne, 2016-08-24 14:01:48]

lgtm

[timvolodine, 2016-08-24 15:42:34]

On 2016/08/24 14:01:48, Torne wrote:
> lgtm

thanks all!

[timvolodine, 2016-08-24 15:42:41]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-08-24 15:42:42]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org,
tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2264633002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-24 15:43:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:51:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[timvolodine, 2016-08-24 18:26:00]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:20:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[timvolodine, 2016-08-25 04:41:57]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-25 04:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:46:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 05:47:53]

Description was changed from

==========
[Android] Add spellchecking support in android_webview.

Add spellcheck functionality to webview. Spellchecking
feature will be enabled if the kEnableAndroidSpellChecker
flag is present.

Historical note:
Blink used to have unified_textchecker_enabled setting
which was false by default in android webview and
needed to be enabled in order for spellchecking to work.
It was recently removed in
https://codereview.chromium.org/2235643002/ though.

BUG=583616, 629609
==========

to

==========
[Android] Add spellchecking support in android_webview.

Add spellcheck functionality to webview. Spellchecking
feature will be enabled if the kEnableAndroidSpellChecker
flag is present.

Historical note:
Blink used to have unified_textchecker_enabled setting
which was false by default in android webview and
needed to be enabled in order for spellchecking to work.
It was recently removed in
https://codereview.chromium.org/2235643002/ though.

BUG=583616, 629609

Committed: https://crrev.com/469d6f7b21d83880658cef21112fa20841a4af1b
Cr-Commit-Position: refs/heads/master@{#414331}
==========

[commit-bot: I haz the power, 2016-08-25 05:47:54]

Patchset 3 (id:??) landed as
https://crrev.com/469d6f7b21d83880658cef21112fa20841a4af1b
Cr-Commit-Position: refs/heads/master@{#414331}