[Android] Add spellchecking support in android_webview.

android_webview/lib/main/aw_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/lib/main/aw_main_delegate.h"
 
 #include <memory>
 
 #include "android_webview/browser/aw_content_browser_client.h"
 #include "android_webview/browser/browser_view_renderer.h"
@@ skipping 14 matching lines @@
 #include "base/android/apk_assets.h"
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
 #include "cc/base/switches.h"
 #include "components/crash/content/app/breakpad_linux.h"
 #include "components/external_video_surface/browser/android/external_video_surface_container_impl.h"
+#include "components/spellcheck/common/spellcheck_switches.h"
 #include "content/public/browser/android/browser_media_player_manager_register.h"
 #include "content/public/browser/browser_main_runner.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/content_descriptors.h"
 #include "content/public/common/content_switches.h"
 #include "gin/public/isolate_holder.h"
 #include "gin/v8_initializer.h"
 #include "gpu/command_buffer/client/gl_in_process_context.h"
 #include "gpu/command_buffer/service/gpu_switches.h"
 #include "media/base/media_switches.h"
@@ skipping 87 matching lines @@
         gin::V8Initializer::GetSnapshotFilePath(false).AsUTF8Unsafe());
   }
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
   if (cl->HasSwitch(switches::kWebViewSandboxedRenderer)) {
     cl->AppendSwitch(switches::kInProcessGPU);
     cl->AppendSwitchASCII(switches::kRendererProcessLimit, "1");
     cl->AppendSwitch(switches::kDisableRendererBackgrounding);
   }
 
+#if defined(ENABLE_SPELLCHECK)
+  cl->AppendSwitch(spellcheck::switches::kEnableAndroidSpellChecker);

[Tobias Sargeant, 2016/08/23 14:17:58]

I don't think we want to unilaterally enable this initially - I thought the plan
was to set it manually in /data/local/tmp/webview-command-line for testing?

Also, when this flag is enabled, don't we also need to enable the unified editor
flag?

[timvolodine, 2016/08/23 15:29:18]

right sorry forgot to remove this after testing locally. The unified_editor flag
was removed recently in https://codereview.chromium.org/2235643002/, see the
discussion there. 

Although the unified_editor used to be false by default in webview this probably
shouldn't be an issue if we want to enable spellcheck in webview by default
anyway.

+#endif
+
   return false;
 }
 
 void AwMainDelegate::PreSandboxStartup() {
 #if defined(ARCH_CPU_ARM_FAMILY)
   // Create an instance of the CPU class to parse /proc/cpuinfo and cache
   // cpu_brand info.
   base::CPU cpu_info;
 #endif
 
@@ skipping 111 matching lines @@
 #if defined(VIDEO_HOLE)
 content::ExternalVideoSurfaceContainer*
 AwMainDelegate::CreateExternalVideoSurfaceContainer(
     content::WebContents* web_contents) {
   return external_video_surface::ExternalVideoSurfaceContainerImpl::Create(
       web_contents);
 }
 #endif
 
 }  // namespace android_webview