Clean up SecurityOrigin handling around CrossOriginAccessControl::handleRedirect()

Clean up SecurityOrigin handling around CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst

Committed: https://crrev.com/f06159edd793696afba02d1d8a105141f2b26185
Cr-Commit-Position: refs/heads/master@{#413418}

[tyoshino (SeeGerritForStatus), 2016-08-19 08:09:45]

Description was changed from

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

BUG=none
==========

to

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-08-19 08:47:21]

Description was changed from

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
==========

to

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-08-19 08:47:21]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org

[tyoshino (SeeGerritForStatus), 2016-08-19 08:47:44]

BTW, Mike, your name is still set to "Mike West (OOO until 15th)". Update or
clear?

[tyoshino (SeeGerritForStatus), 2016-08-19 08:47:58]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 08:48:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-08-19 08:51:29]

Sorry, please hold on. I see some bugs.

[tyoshino (SeeGerritForStatus), 2016-08-19 09:07:31]

On 2016/08/19 08:51:29, tyoshino wrote:
> Sorry, please hold on. I see some bugs.

Hmm, it looks just some hiccup in layout test runner. Never mind.

[Mike West, 2016-08-19 09:17:32]

LGTM.

Thanks for poking me to update the label. I forgot about that completely!

That said, I'm OOO all next week, so... Summertime! :)

[tyoshino (SeeGerritForStatus), 2016-08-19 10:04:52]

On 2016/08/19 09:17:32, Mike West (OOO until 29th) wrote:
> Thanks for poking me to update the label. I forgot about that completely!
> 
> That said, I'm OOO all next week, so... Summertime! :)

Got it!

[commit-bot: I haz the power, 2016-08-19 13:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:24:07]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-08-22 03:47:23]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-08-22 03:47:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2264503002/#ps60001
(title: "Rebase")

[tyoshino (SeeGerritForStatus), 2016-08-22 03:47:26]

The CQ bit was unchecked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-08-22 03:47:34]

Description was changed from

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
==========

to

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst
==========

[tyoshino (SeeGerritForStatus), 2016-08-22 03:47:53]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-08-22 03:48:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 08:11:01]

Description was changed from

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst
==========

to

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst
==========

[commit-bot: I haz the power, 2016-08-22 08:11:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-22 08:13:55]

Description was changed from

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst
==========

to

==========
Clean up SecurityOrigin handling around
CrossOriginAccessControl::handleRedirect()

- improve readability by reordering code and giving better variable
  names.
  - introduce securityOriginForHeader and stop reusing |securityOrigin|
    in handleRedirect()
  - originalURL -> lastURL as there can be multiple redirects to follow
- update some of the comments to refer to the sections of the up-to-date
  Fetch Standard
- make arguments const where possible
- add TODOs for improving spec conformance later
- drop PassRefPtr from setHTTPOrigin() and addHTTPOriginIfNeeded() and
  add const instead as they don't pass the SecurityOrigin to anywhere.

BUG=none
R=mkwst

Committed: https://crrev.com/f06159edd793696afba02d1d8a105141f2b26185
Cr-Commit-Position: refs/heads/master@{#413418}
==========

[commit-bot: I haz the power, 2016-08-22 08:13:55]

Patchset 4 (id:??) landed as
https://crrev.com/f06159edd793696afba02d1d8a105141f2b26185
Cr-Commit-Position: refs/heads/master@{#413418}