third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2264503002: Clean up SecurityOrigin handling around CrossOriginAccessControl::handleRedirect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2264503002: Clean up SecurityOrigin handling around CrossOriginAccessControl::handleRedirect() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | third_party/WebKit/Source/core/loader/PingLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index 31434e9066ea1d0572516cd121fa3e9238fea66f..1d41d43eb03b3fb373b51a9bc2f5e8b2f265cf74 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -141,7 +141,7 @@ ResourceRequest FrameLoader::resourceRequestFromHistoryItem(HistoryItem* item, W

request.setHTTPBody(formData);

request.setHTTPContentType(item->formContentType());

RefPtr<SecurityOrigin> securityOrigin = SecurityOrigin::createFromString(item->referrer().referrer);

- request.addHTTPOriginIfNeeded(securityOrigin);

+ request.addHTTPOriginIfNeeded(securityOrigin.get());

}

return request;

}

@@ -812,7 +812,7 @@ void FrameLoader::setReferrerForFrameRequest(FrameLoadRequest& frameRequest)

request.setHTTPReferrer(referrer);

RefPtr<SecurityOrigin> referrerOrigin = SecurityOrigin::createFromString(referrer.referrer);

- request.addHTTPOriginIfNeeded(referrerOrigin);

+ request.addHTTPOriginIfNeeded(referrerOrigin.get());

}

FrameLoadType FrameLoader::determineFrameLoadType(const FrameLoadRequest& request)