Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2264483002: Replace ASSERT()s with DCHECK*() in core/html/imports/. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, tfarina, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT()s with DCHECK*() in core/html/imports/. This CL has no behavior changes. BUG=596760 Committed: https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f Cr-Commit-Position: refs/heads/master@{#413095}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
tkent
kochi@, would you review this please?
4 years, 4 months ago (2016-08-19 08:20:38 UTC) #4
kochi
lgtm
4 years, 4 months ago (2016-08-19 09:53:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264483002/1
4 years, 4 months ago (2016-08-19 09:53:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 09:57:24 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 09:58:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8dd9554617bcac53dea5173d382d7e66b96109f
Cr-Commit-Position: refs/heads/master@{#413095}

Powered by Google App Engine
This is Rietveld 408576698