Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp

Issue 2264483002: Replace ASSERT()s with DCHECK*() in core/html/imports/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
diff --git a/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp b/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
index e40a4044b5fcae8e26c93213fff0321454b89684..a70e136a3a30cce7f50576008982acee8c76334c 100644
--- a/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
+++ b/third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp
@@ -100,7 +100,7 @@ void HTMLImportChild::dispose()
if (parent())
parent()->removeChild(this);
- ASSERT(m_loader);
+ DCHECK(m_loader);
m_loader->removeImport(this);
m_loader = nullptr;
@@ -112,7 +112,7 @@ void HTMLImportChild::dispose()
Document* HTMLImportChild::document() const
{
- ASSERT(m_loader);
+ DCHECK(m_loader);
return m_loader->document();
}
@@ -139,7 +139,7 @@ void HTMLImportChild::invalidateCustomElementMicrotaskStep()
void HTMLImportChild::createCustomElementMicrotaskStepIfNeeded()
{
- ASSERT(!m_customElementMicrotaskStep);
+ DCHECK(!m_customElementMicrotaskStep);
if (!hasFinishedLoading() && !formsCycle()) {
m_customElementMicrotaskStep = V0CustomElement::didCreateImport(this);
@@ -148,7 +148,7 @@ void HTMLImportChild::createCustomElementMicrotaskStepIfNeeded()
bool HTMLImportChild::hasFinishedLoading() const
{
- ASSERT(m_loader);
+ DCHECK(m_loader);
return m_loader->isDone() && m_loader->microtaskQueue()->isEmpty() && !m_customElementMicrotaskStep;
}
@@ -156,14 +156,14 @@ bool HTMLImportChild::hasFinishedLoading() const
HTMLImportLoader* HTMLImportChild::loader() const
{
// This should never be called after dispose().
- ASSERT(m_loader);
+ DCHECK(m_loader);
return m_loader;
}
void HTMLImportChild::setClient(HTMLImportChildClient* client)
{
- ASSERT(client);
- ASSERT(!m_client);
+ DCHECK(client);
+ DCHECK(!m_client);
m_client = client;
}

Powered by Google App Engine
This is Rietveld 408576698