Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2264443002: Do not automatically maximize the window if the maximized bounds can be controlled by the client in… (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG=635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566} (cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f) Committed: https://chromium.googlesource.com/chromium/src/+/739c479e48067b5df7fe7698563289d429a0759a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 4 months ago (2016-08-19 00:41:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
739c479e48067b5df7fe7698563289d429a0759a.

Powered by Google App Engine
This is Rietveld 408576698