Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2264403003: Remove unused variables in StreamTexure (Closed)

Created:
4 years, 4 months ago by tguilbert
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused variables in StreamTexure The changes in 8f2032aeb81c2a6a48ed2ed622859b59d84fbbaa remove the code that used the variables that were used introduced in f52b1e6228ee51bb78886d2a17155d3e2acbb0da. This change removes those variables and the associated code in the destructor. BUG=640275 TEST=still builds. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/af986e2dad52ea6c7594682936724a1d08179595 Cr-Commit-Position: refs/heads/master@{#414839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M gpu/ipc/service/stream_texture_android.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/ipc/service/stream_texture_android.cc View 4 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tguilbert
Hello, Can you PTAL to make sure I am not removing anything that was actually ...
4 years, 4 months ago (2016-08-23 18:38:59 UTC) #3
tguilbert
Ping. Thanks!
4 years, 3 months ago (2016-08-26 04:14:34 UTC) #8
Tobias Sargeant
On 2016/08/26 04:14:34, ThomasGuilbert wrote: > Ping. Thanks! LGTM, these members are definitely unused, but ...
4 years, 3 months ago (2016-08-26 08:41:26 UTC) #9
tguilbert
Awesome! sievers, can you please OWNERS review this? Thanks, Thomas
4 years, 3 months ago (2016-08-26 19:41:27 UTC) #11
no sievers
lgtm
4 years, 3 months ago (2016-08-26 21:37:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264403003/1
4 years, 3 months ago (2016-08-26 21:47:53 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 22:41:31 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:43:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af986e2dad52ea6c7594682936724a1d08179595
Cr-Commit-Position: refs/heads/master@{#414839}

Powered by Google App Engine
This is Rietveld 408576698