Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2264353004: MD Settings: Keep sliding subpages within card (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@TransitionsNoTestsFakeRebase
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Keep sliding subpages within card The sliding subpages in neon-animated-pages (settings-animated-pages) shouldn't protrude past the edges of the card when sliding left/right. A stacking context ensures this without screwing up positioning of the card. BUG=640315 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cb981f6a9b1d0a65e068c9fa3e2ef62997cfd199 Cr-Commit-Position: refs/heads/master@{#414866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
michaelpg
4 years, 4 months ago (2016-08-23 20:18:32 UTC) #3
dschuyler
Interesting and useful to know about. LGTM
4 years, 4 months ago (2016-08-23 20:40:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264353004/1
4 years, 3 months ago (2016-08-26 21:41:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 00:04:12 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 00:07:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb981f6a9b1d0a65e068c9fa3e2ef62997cfd199
Cr-Commit-Position: refs/heads/master@{#414866}

Powered by Google App Engine
This is Rietveld 408576698