MD Settings: fix collapse animation once and for all

MD Settings: fix collapse animation once and for all

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f
Cr-Commit-Position: refs/heads/master@{#414289}

[michaelpg, 2016-08-10 04:34:01]

Description was changed from

==========
MD Settings: fix collapse animation once and for all

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
==========

to

==========
MD Settings: fix collapse animation once and for all

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-15 20:08:13]

Patchset #2 (id:20001) has been deleted

[michaelpg, 2016-08-15 20:08:37]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-08-15 20:08:38]

PTAL.

[Dan Beam, 2016-08-17 03:01:03]

i either agreed with all of this code or didn't understand it

either way, lgtm!

https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:162:
finished = true;
could we maybe add some new lines in this code?

[michaelpg, 2016-08-18 18:01:31]

On 2016/08/17 03:01:03, Dan Beam wrote:
> i either agreed with all of this code or didn't understand it

didn't understand is no good... was it the layout bits, the cancel/finish logic,
or something else?

> 
> either way, lgtm!
> 
>
https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/settings/settings_page/main_page_behavior.js
> (right):
> 
>
https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_page/main_page_behavior.js:162:
> finished = true;
> could we maybe add some new lines in this code?

[michaelpg, 2016-08-19 01:05:56]

Patchset #3 (id:60001) has been deleted

[michaelpg, 2016-08-19 21:55:01]

https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2230123002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:162:
finished = true;
On 2016/08/17 03:01:02, Dan Beam wrote:
> could we maybe add some new lines in this code?

Done.

[michaelpg, 2016-08-19 21:55:05]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-19 21:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps100001
(title: "newlines")

[commit-bot: I haz the power, 2016-08-19 21:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:31:09]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-08-20 00:59:27]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:59:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:14:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-08-23 19:48:52]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-23 19:48:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps300001
(title: "jsdoc")

[michaelpg, 2016-08-23 19:49:23]

The CQ bit was unchecked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-23 19:49:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-23 20:14:49]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-23 20:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps320001
(title: "jsdoc")

[commit-bot: I haz the power, 2016-08-23 20:15:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-23 20:40:22]

The CQ bit was unchecked by michaelpg@chromium.org

[michaelpg, 2016-08-23 20:44:14]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-23 20:44:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps340001
(title: "fix subpage height")

[commit-bot: I haz the power, 2016-08-23 20:44:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 23:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:39:41]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-08-24 18:35:11]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-24 18:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps360001
(title: "asan not msan")

[commit-bot: I haz the power, 2016-08-24 18:36:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 18:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 18:39:23]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelpg, 2016-08-24 20:25:20]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-24 20:25:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps380001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-24 20:26:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:30:08]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelpg, 2016-08-24 22:14:54]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-24 22:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2230123002/#ps400001
(title: "rebase, rebase fix (doWhenReady)")

[commit-bot: I haz the power, 2016-08-24 22:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 01:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 01:08:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[michaelpg, 2016-08-25 02:13:08]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-25 02:14:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:29:27]

Committed patchset #19 (id:400001)

[commit-bot: I haz the power, 2016-08-25 03:33:07]

Description was changed from

==========
MD Settings: fix collapse animation once and for all

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: fix collapse animation once and for all

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f
Cr-Commit-Position: refs/heads/master@{#414289}
==========

[commit-bot: I haz the power, 2016-08-25 03:33:09]

Patchset 19 (id:??) landed as
https://crrev.com/6c4ce51ea1886af904821bdd1dd0d6d3e6932d6f
Cr-Commit-Position: refs/heads/master@{#414289}