chrome/browser/media/router/presentation_service_delegate_impl.cc - Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Mark's comments, add unit test for CMWMS Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_request.h ('K') | « chrome/browser/media/router/presentation_request_unittest.cc ('k') | chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc » ('j') | chrome/browser/ui/webui/media_router/cast_modes_with_media_sources.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.cc b/chrome/browser/media/router/presentation_service_delegate_impl.cc

index 7ac0b82de939bde08dc48d08aff34f1d032ddbf4..a3c9b316086f13def562f3b1d91bad736d31dc3a 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl.cc

@@ -548,8 +548,8 @@ void PresentationFrameManager::SetDefaultPresentationUrl(

} else {

DCHECK(!callback.is_null());

GURL frame_url(GetLastCommittedURLForFrame(render_frame_host_id));

- PresentationRequest request(render_frame_host_id, default_presentation_url,

- frame_url);

+ PresentationRequest request(

+ render_frame_host_id, {default_presentation_url}, frame_url);

default_presentation_started_callback_ = callback;

SetDefaultPresentationRequest(request);

}