chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc - Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Mark's comments, add unit test for CMWMS Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/presentation_request.h ('K') | « chrome/browser/media/router/presentation_service_delegate_impl.cc ('k') | chrome/browser/ui/webui/media_router/cast_modes_with_media_sources.h » ('j') | chrome/browser/ui/webui/media_router/cast_modes_with_media_sources.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

diff --git a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

index 6d4aa38b187247581a20b18d37758dbd1cea107c..9cbe3e20051801f2af8f3b877f593cf1aac9c16b 100644

--- a/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

+++ b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

@@ -104,7 +104,7 @@ class PresentationServiceDelegateImplTest

// Should not trigger callback since request doesn't match.

std::string presentation_url2("http://bar.fakeUrl");

PresentationRequest different_request(

- RenderFrameHostId(100, 200), presentation_url2,

+ RenderFrameHostId(100, 200), {presentation_url2},

GURL("http://anotherFrameUrl.fakeUrl"));

MediaRoute* media_route = new MediaRoute(

"differentRouteId", MediaSourceForPresentationUrl(presentation_url2),

@@ -333,7 +333,7 @@ TEST_F(PresentationServiceDelegateImplTest,

std::string url1("http://foo.fakeUrl");

PresentationRequest observed_request1(

- RenderFrameHostId(render_process_id, routing_id), url1, frame_url);

+ RenderFrameHostId(render_process_id, routing_id), {url1}, frame_url);

EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request1)))

.Times(1);

delegate_impl_->SetDefaultPresentationUrl(render_process_id, routing_id, url1,

@@ -348,7 +348,7 @@ TEST_F(PresentationServiceDelegateImplTest,

std::string url2("http://youtube.com");

PresentationRequest observed_request2(

- RenderFrameHostId(render_process_id, routing_id), url2, frame_url);

+ RenderFrameHostId(render_process_id, routing_id), {url2}, frame_url);

EXPECT_CALL(observer, OnDefaultPresentationChanged(Equals(observed_request2)))

.Times(1);

delegate_impl_->SetDefaultPresentationUrl(render_process_id, routing_id, url2,