Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: public/web/WebViewClient.h

Issue 226413004: Move modal dialogs from WebViewClient to WebFrameClient, part 2/3. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove redundancy Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index 1a248f601844f07d00c46c4371ec141773179e22..49ca41b87df072d74b72533a590de1f6c21f18f7 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -158,6 +158,7 @@ public:
// indicating that the default action should be suppressed.
virtual bool handleCurrentKeyboardEvent() { return false; }
+
// Dialogs -------------------------------------------------------------
// This method opens the color chooser and returns a new WebColorChooser
@@ -200,33 +201,6 @@ public:
// Move the existing notifation popup to the new anchor position.
virtual void moveValidationMessage(const WebRect& anchorInRootView) { }
- // Displays a modal alert dialog containing the given message. Returns
- // once the user dismisses the dialog.
- virtual void runModalAlertDialog(
- WebLocalFrame*, const WebString& message) { }
-
- // Displays a modal confirmation dialog with the given message as
- // description and OK/Cancel choices. Returns true if the user selects
- // 'OK' or false otherwise.
- virtual bool runModalConfirmDialog(
- WebLocalFrame*, const WebString& message) { return false; }
-
- // Displays a modal input dialog with the given message as description
- // and OK/Cancel choices. The input field is pre-filled with
- // defaultValue. Returns true if the user selects 'OK' or false
- // otherwise. Upon returning true, actualValue contains the value of
- // the input field.
- virtual bool runModalPromptDialog(
- WebLocalFrame*, const WebString& message, const WebString& defaultValue,
- WebString* actualValue) { return false; }
-
- // Displays a modal confirmation dialog containing the given message as
- // description and OK/Cancel choices, where 'OK' means that it is okay
- // to proceed with closing the view. Returns true if the user selects
- // 'OK' or false otherwise.
- virtual bool runModalBeforeUnloadDialog(
- WebLocalFrame*, const WebString& message) { return true; }
-
// UI ------------------------------------------------------------------
@@ -269,6 +243,7 @@ public:
// Returns comma separated list of accept languages.
virtual WebString acceptLanguages() { return WebString(); }
+
// Session history -----------------------------------------------------
// Tells the embedder to navigate back or forward in session history by
@@ -287,6 +262,7 @@ public:
// Notifies embedder about an accessibility event.
virtual void postAccessibilityEvent(const WebAXObject&, WebAXEvent) { }
+
// Developer tools -----------------------------------------------------
// Called to notify the client that the inspector's settings were
@@ -295,6 +271,7 @@ public:
virtual void didUpdateInspectorSetting(const WebString& key, const WebString& value) { }
+
// Geolocation ---------------------------------------------------------
// Access the embedder API for (client-based) geolocation client .
@@ -302,6 +279,7 @@ public:
// Access the embedder API for (non-client-based) geolocation services.
virtual WebGeolocationService* geolocationService() { return 0; }
+
// Speech --------------------------------------------------------------
// Access the embedder API for speech input services.
@@ -311,6 +289,7 @@ public:
// Access the embedder API for speech recognition services.
virtual WebSpeechRecognizer* speechRecognizer() { return 0; }
+
// Zoom ----------------------------------------------------------------
// Informs the browser that the zoom levels for this frame have changed from
@@ -321,6 +300,7 @@ public:
// action that wasn't initiated by the client.
virtual void zoomLevelChanged() { }
+
// Navigator Content Utils --------------------------------------------
// Registers a new URL handler for the given protocol.
@@ -357,6 +337,7 @@ public:
return WebCustomHandlersNew;
}
+
// Visibility -----------------------------------------------------------
// Returns the current visibility of the WebView.
@@ -365,10 +346,12 @@ public:
return WebPageVisibilityStateVisible;
}
+
// Media Streams -------------------------------------------------------
virtual WebUserMediaClient* userMediaClient() { return 0; }
+
// Web MIDI -------------------------------------------------------------
virtual WebMIDIClient* webMIDIClient() { return 0; }
@@ -390,6 +373,7 @@ public:
// Cancels any previously scheduled content intents that have not yet launched.
virtual void cancelScheduledContentIntents() { }
+
// Draggable regions ----------------------------------------------------
// Informs the browser that the draggable regions have been updated.
« no previous file with comments | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698