public/web/WebFrameClient.h - Issue 226413004: Move modal dialogs from WebViewClient to WebFrameClient, part 2/3.

Unified Diff: public/web/WebFrameClient.h

Issue 226413004: Move modal dialogs from WebViewClient to WebFrameClient, part 2/3. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove redundancy Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 02b17db3911f2b859514da941c9b54e1d790def6..f6d2d4876596aecab419c0aaea0b1b0e9d37a5bf 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -152,6 +152,7 @@ public:

// Called when a watched CSS selector matches or stops matching.

virtual void didMatchCSS(WebLocalFrame*, const WebVector<WebString>& newlyMatchingSelectors, const WebVector<WebString>& stoppedMatchingSelectors) { }

// Console messages ----------------------------------------------------

// Whether or not we should report a detailed message for the given source.

@@ -160,6 +161,7 @@ public:

// A new message was added to the console.

virtual void didAddMessageToConsole(const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLine, const WebString& stackTrace) { }

// Load commands -------------------------------------------------------

// The client should handle the navigation externally.

@@ -254,6 +256,7 @@ public:

// WARNING: This method may be called very frequently.

virtual void didUpdateCurrentHistoryItem(WebLocalFrame*) { }

// Editing -------------------------------------------------------------

// These methods allow the client to intercept and overrule editing

@@ -261,6 +264,34 @@ public:

virtual void didChangeSelection(bool isSelectionEmpty) { }

+ // Dialogs -------------------------------------------------------------

+ // Displays a modal alert dialog containing the given message. Returns

+ // once the user dismisses the dialog.

+ virtual void runModalAlertDialog(const WebString& message) { }

+ // Displays a modal confirmation dialog with the given message as

+ // description and OK/Cancel choices. Returns true if the user selects

+ // 'OK' or false otherwise.

+ virtual bool runModalConfirmDialog(const WebString& message) { return false; }

+ // Displays a modal input dialog with the given message as description

+ // and OK/Cancel choices. The input field is pre-filled with

+ // defaultValue. Returns true if the user selects 'OK' or false

+ // otherwise. Upon returning true, actualValue contains the value of

+ // the input field.

+ virtual bool runModalPromptDialog(

+ const WebString& message, const WebString& defaultValue,

+ WebString* actualValue) { return false; }

+ // Displays a modal confirmation dialog containing the given message as

+ // description and OK/Cancel choices, where 'OK' means that it is okay

+ // to proceed with closing the view. Returns true if the user selects

+ // 'OK' or false otherwise.

+ virtual bool runModalBeforeUnloadDialog(

+ bool isReload, const WebString& message) { return true; }

// UI ------------------------------------------------------------------

// Shows a context menu with commands relevant to a specific element on

@@ -325,6 +356,7 @@ public:

// The loaders in this frame have been stopped.

virtual void didAbortLoading(WebLocalFrame*) { }

// Script notifications ------------------------------------------------

// Notifies that a new script context has been created for this frame.

@@ -335,6 +367,7 @@ public:

// WebKit is about to release its reference to a v8 context for a frame.

virtual void willReleaseScriptContext(WebLocalFrame*, v8::Handle<v8::Context>, int worldId) { }

// Geometry notifications ----------------------------------------------

// The frame's document finished the initial non-empty layout of a page.

@@ -350,6 +383,7 @@ public:

// notify that the <body> will be attached soon.

virtual void willInsertBody(WebLocalFrame*) { }

// Find-in-page notifications ------------------------------------------

// Notifies how many matches have been found so far, for a given

@@ -367,6 +401,7 @@ public:

virtual void reportFindInPageSelection(

int identifier, int activeMatchOrdinal, const WebRect& selection) { }

// Quota ---------------------------------------------------------

// Requests a new quota size for the origin's storage.

@@ -387,11 +422,13 @@ public:

// A WebSocket object is going to open new stream connection.

virtual void willOpenSocketStream(WebSocketStreamHandle*) { }

// MediaStream -----------------------------------------------------

// A new WebRTCPeerConnectionHandler is created.

virtual void willStartUsingPeerConnectionHandler(WebLocalFrame*, WebRTCPeerConnectionHandler*) { }

// Messages ------------------------------------------------------

// Notifies the embedder that a postMessage was issued on this frame, and

@@ -412,6 +449,7 @@ public:

// header. An empty string indicates that no DNT header will be send.

virtual WebString doNotTrackValue(WebLocalFrame*) { return WebString(); }

// WebGL ------------------------------------------------------

// Asks the embedder whether WebGL is allowed for the given WebFrame.

« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | public/web/WebViewClient.h » ('j') | no next file with comments »