Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226413004: Move modal dialogs from WebViewClient to WebFrameClient, part 2/3. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move modal dialogs from WebViewClient to WebFrameClient, part 2/3. BUG=304341 TEST=modal dialogs still work Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171180

Patch Set 1 #

Patch Set 2 : remove redundancy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -40 lines) Patch
M Source/web/ChromeClientImpl.cpp View 1 3 chunks +18 lines, -13 lines 0 comments Download
M public/web/WebFrameClient.h View 1 10 chunks +38 lines, -0 lines 0 comments Download
M public/web/WebViewClient.h View 1 11 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
Avi (use Gerrit)
Part 1 is https://codereview.chromium.org/226503002/, creating the alternate frame-based callback path.
6 years, 8 months ago (2014-04-04 22:50:45 UTC) #1
dglazkov
lgtm
6 years, 8 months ago (2014-04-06 02:30:17 UTC) #2
Avi (use Gerrit)
Dmitri, PTAL. This removes the redundant WebFrame parameters.
6 years, 8 months ago (2014-04-07 23:29:13 UTC) #3
dglazkov
even betterer lgtm
6 years, 8 months ago (2014-04-07 23:30:19 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-08 23:04:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/226413004/20001
6 years, 8 months ago (2014-04-08 23:04:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 23:47:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-08 23:48:00 UTC) #8
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-08 23:50:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/226413004/20001
6 years, 8 months ago (2014-04-08 23:50:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 00:06:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-09 00:06:18 UTC) #12
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-09 00:08:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/226413004/20001
6 years, 8 months ago (2014-04-09 00:08:30 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 00:12:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-09 00:12:20 UTC) #16
Avi (use Gerrit)
OK, so this looks genuinely broken somehow. Let me look.
6 years, 8 months ago (2014-04-09 00:24:24 UTC) #17
Avi (use Gerrit)
On 2014/04/09 00:24:24, Avi wrote: > OK, so this looks genuinely broken somehow. Let me ...
6 years, 8 months ago (2014-04-09 15:36:10 UTC) #18
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-09 20:41:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/226413004/20001
6 years, 8 months ago (2014-04-09 20:41:34 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 20:43:44 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-09 20:43:44 UTC) #22
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-09 20:46:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/226413004/20001
6 years, 8 months ago (2014-04-09 20:46:50 UTC) #24
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:47:49 UTC) #25
Message was sent while issue was closed. 
Change committed as 171180

Powered by Google App Engine
This is Rietveld 408576698