components/password_manager/content/browser/credential_manager_impl_unittest.cc - Issue 2263933002: Make FormFetcher a PasswordStoreConsumer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl_unittest.cc

Issue 2263933002: Make FormFetcher a PasswordStoreConsumer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_form_fetcher

Patch Set: Also operator= is now default Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl_unittest.cc b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

index e3ce344abdcc401c053a16af927f8ca70b38c0ac..4c0840bd5d0529f6676c068b265dc60aa246e7f4 100644

--- a/components/password_manager/content/browser/credential_manager_impl_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

@@ -408,7 +408,8 @@ TEST_F(CredentialManagerImplTest, CredentialManagerOnStore) {

RunAllPendingTasks();

EXPECT_TRUE(called);

- EXPECT_TRUE(client_->pending_manager()->HasCompletedMatching());

+ EXPECT_EQ(FormFetcher::State::NOT_WAITING,

+ client_->pending_manager()->form_fetcher()->GetState());

autofill::PasswordForm new_form =

client_->pending_manager()->pending_credentials();

@@ -441,7 +442,8 @@ TEST_F(CredentialManagerImplTest, CredentialManagerOnStoreFederated) {

RunAllPendingTasks();

EXPECT_TRUE(called);

- EXPECT_TRUE(client_->pending_manager()->HasCompletedMatching());

+ EXPECT_EQ(FormFetcher::State::NOT_WAITING,

+ client_->pending_manager()->form_fetcher()->GetState());

autofill::PasswordForm new_form =

client_->pending_manager()->pending_credentials();

@@ -479,7 +481,8 @@ TEST_F(CredentialManagerImplTest, StoreFederatedAfterPassword) {

RunAllPendingTasks();

EXPECT_TRUE(called);

- EXPECT_TRUE(client_->pending_manager()->HasCompletedMatching());

+ EXPECT_EQ(FormFetcher::State::NOT_WAITING,

+ client_->pending_manager()->form_fetcher()->GetState());

client_->pending_manager()->Save();

RunAllPendingTasks();