components/autofill/core/common/save_password_progress_logger.cc - Issue 2263933002: Make FormFetcher a PasswordStoreConsumer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 2263933002: Make FormFetcher a PasswordStoreConsumer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_form_fetcher

Patch Set: Also operator= is now default Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/content/browser/credential_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index b2dd78b63c8f795cdbe4f1ed14422835d9de257f..5b321019e51fd98a87b34984858de38be05320fe 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -318,11 +318,11 @@ std::string SavePasswordProgressLogger::GetStringFromID(

case SavePasswordProgressLogger::STRING_BEST_SCORE:

return "best_score";

case SavePasswordProgressLogger::STRING_ON_GET_STORE_RESULTS_METHOD:

- return "PasswordFormManager::OnGetPasswordStoreResults";

+ return "FormFetcherImpl::OnGetPasswordStoreResults";

case SavePasswordProgressLogger::STRING_NUMBER_RESULTS:

return "Number of results from the password store";

- case SavePasswordProgressLogger::STRING_FETCH_LOGINS_METHOD:

- return "PasswordFormManager::FetchMatchingLoginsFromPasswordStore";

+ case SavePasswordProgressLogger::STRING_FETCH_METHOD:

+ return "FormFetcherImpl::Fetch";

case SavePasswordProgressLogger::STRING_NO_STORE:

return "PasswordStore is not available";

case SavePasswordProgressLogger::STRING_CREATE_LOGIN_MANAGERS_METHOD:

@@ -346,8 +346,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(

return "PasswordFormManager::ProcessFrame";

case SavePasswordProgressLogger::STRING_FORM_SIGNATURE:

return "Signature of form";

- case SavePasswordProgressLogger::STRING_FORM_MANAGER_STATE:

- return "PasswordFormManager::state_";

+ case SavePasswordProgressLogger::STRING_FORM_FETCHER_STATE:

+ return "FormFetcherImpl::state_";

case SavePasswordProgressLogger::STRING_ADDING_SIGNATURE:

return "Adding manager for form";

case SavePasswordProgressLogger::STRING_UNOWNED_INPUTS_VISIBLE: