Make CFX_Color constructor explicit

Make CFX_Color constructor explicit

Change the places which require implicit construction, and make the
construction from ARGB_Color explicit.

Committed: https://pdfium.googlesource.com/pdfium/+/9b99ebf5159d98cc83fb2e8ebac6750e158841d6

[Wei Li, 2016-08-22 17:35:22]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-08-22 17:43:57]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 17:44:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:54:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 17:54:16]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-22 19:27:31]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-22 19:27:32]

pls review, thanks

[Lei Zhang, 2016-08-22 19:30:37]

lgtm

https://codereview.chromium.org/2263923003/diff/40001/xfa/fxgraphics/cfx_color.h
File xfa/fxgraphics/cfx_color.h (right):

https://codereview.chromium.org/2263923003/diff/40001/xfa/fxgraphics/cfx_colo...
xfa/fxgraphics/cfx_color.h:22: explicit CFX_Color(CFX_Pattern* pattern, const
FX_ARGB argb);
Nit explicit

[Wei Li, 2016-08-22 19:38:03]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 19:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 19:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 19:46:04]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-22 20:35:42]

thanks

https://codereview.chromium.org/2263923003/diff/40001/xfa/fxgraphics/cfx_color.h
File xfa/fxgraphics/cfx_color.h (right):

https://codereview.chromium.org/2263923003/diff/40001/xfa/fxgraphics/cfx_colo...
xfa/fxgraphics/cfx_color.h:22: explicit CFX_Color(CFX_Pattern* pattern, const
FX_ARGB argb);
On 2016/08/22 19:30:37, Lei Zhang wrote:
> Nit explicit

Done.

[Wei Li, 2016-08-22 20:36:43]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-22 20:36:44]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2263923003/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-08-22 20:36:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 20:37:07]

Description was changed from

==========
Make CFX_Color constructor explicit

Change the places which require implicit construction, and make the
construction from ARGB_Color explicit.
==========

to

==========
Make CFX_Color constructor explicit

Change the places which require implicit construction, and make the
construction from ARGB_Color explicit.

Committed:
https://pdfium.googlesource.com/pdfium/+/9b99ebf5159d98cc83fb2e8ebac6750e1588...
==========

[commit-bot: I haz the power, 2016-08-22 20:37:08]

Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/9b99ebf5159d98cc83fb2e8ebac6750e1588...