Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: xfa/fwl/theme/cfwl_comboboxtp.cpp

Issue 2263923003: Make CFX_Color constructor explicit (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fwl/theme/cfwl_carettp.cpp ('k') | xfa/fwl/theme/cfwl_monthcalendartp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/theme/cfwl_comboboxtp.cpp
diff --git a/xfa/fwl/theme/cfwl_comboboxtp.cpp b/xfa/fwl/theme/cfwl_comboboxtp.cpp
index 92f2296105727a14169c82aaf2902fb99cc0c1fc..9fdb77682082793d7aedd25135e363f31aebfa57 100644
--- a/xfa/fwl/theme/cfwl_comboboxtp.cpp
+++ b/xfa/fwl/theme/cfwl_comboboxtp.cpp
@@ -47,18 +47,19 @@ FX_BOOL CFWL_ComboBoxTP::DrawBackground(CFWL_ThemeBackground* pParams) {
path.Create();
CFX_RectF& rect = pParams->m_rtPart;
path.AddRectangle(rect.left, rect.top, rect.width, rect.height);
- CFX_Color cr;
+ FX_ARGB argb_color;
switch (pParams->m_dwStates) {
case CFWL_PartState_Selected:
- cr = FWLTHEME_COLOR_BKSelected;
+ argb_color = FWLTHEME_COLOR_BKSelected;
break;
case CFWL_PartState_Disabled:
- cr = FWLTHEME_COLOR_EDGERB1;
+ argb_color = FWLTHEME_COLOR_EDGERB1;
break;
default:
- cr = 0xFFFFFFFF;
+ argb_color = 0xFFFFFFFF;
}
pParams->m_pGraphics->SaveGraphState();
+ CFX_Color cr(argb_color);
pParams->m_pGraphics->SetFillColor(&cr);
pParams->m_pGraphics->FillPath(&path, FXFILL_WINDING, &pParams->m_matrix);
pParams->m_pGraphics->RestoreGraphState();
« no previous file with comments | « xfa/fwl/theme/cfwl_carettp.cpp ('k') | xfa/fwl/theme/cfwl_monthcalendartp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698