Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 3 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index 1f76bb50269badadc2dc054ae39583c98b4d7593..c99c76450da34ab099b350068490007e90820d2e 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -34,23 +34,25 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
// Informs the hosted agent that a client host has detached.
virtual void Detach() = 0;
- // Opens the inspector for this host.
- bool Inspect(BrowserContext* browser_context);
-
// DevToolsAgentHost implementation.
bool AttachClient(DevToolsAgentHostClient* client) override;
void ForceAttachClient(DevToolsAgentHostClient* client) override;
bool DetachClient(DevToolsAgentHostClient* client) override;
bool DispatchProtocolMessage(DevToolsAgentHostClient* client,
const std::string& message) override;
-
bool IsAttached() override;
void InspectElement(DevToolsAgentHostClient* client, int x, int y) override;
std::string GetId() override;
+ std::string GetParentId() override;
+ std::string GetDescription() override;
+ void SetDescriptionOverride(const std::string& description) override;
+ GURL GetFaviconURL() override;
+ base::TimeTicks GetLastActivityTime() override;
BrowserContext* GetBrowserContext() override;
WebContents* GetWebContents() override;
void DisconnectWebContents() override;
void ConnectWebContents(WebContents* wc) override;
+ bool Inspect() override;
// DevToolsProtocolDelegate implementation.
void SendProtocolResponse(int session_id,
@@ -58,7 +60,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
void SendProtocolNotification(const std::string& message) override;
protected:
- DevToolsAgentHostImpl();
+ DevToolsAgentHostImpl(const std::string& id);
~DevToolsAgentHostImpl() override;
virtual bool DispatchProtocolMessage(const std::string& message) = 0;
@@ -79,6 +81,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost,
const std::string id_;
int session_id_;
+ std::string description_;
DevToolsAgentHostClient* client_;
devtools::DevToolsIOContext io_context_;
};
« no previous file with comments | « content/browser/devtools/browser_devtools_agent_host.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698