chrome/browser/ui/webui/inspect_ui.h - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.h

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/device/devtools_android_bridge.cc ('K') | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | components/devtools_discovery/devtools_target_descriptor.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/inspect_ui.h

diff --git a/chrome/browser/ui/webui/inspect_ui.h b/chrome/browser/ui/webui/inspect_ui.h

index 9faee68f28267e87c740da3700196799ad58a239..e44f85ba24c7b1c47fb6706e128111ea534a53e1 100644

--- a/chrome/browser/ui/webui/inspect_ui.h

+++ b/chrome/browser/ui/webui/inspect_ui.h

@@ -22,6 +22,10 @@ class Value;

class ListValue;

}

+namespace content {

+class DevToolsAgentHost;

class Browser;

class DevToolsTargetsUIHandler;

class DevToolsTargetImpl;

@@ -71,8 +75,9 @@ class InspectUI : public content::WebUIController,

DevToolsTargetsUIHandler* FindTargetHandler(

const std::string& source_id);

- DevToolsTargetImpl* FindTarget(const std::string& source_id,

- const std::string& target_id);

+ scoped_refptr<content::DevToolsAgentHost> FindTarget(

+ const std::string& source_id,

+ const std::string& target_id);

void PopulateTargets(const std::string& source_id,

const base::ListValue& targets);