content/browser/devtools/protocol/devtools_protocol_browsertest.cc - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: all done Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('K') | « content/browser/devtools/protocol/browser_handler.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

index 236874de399dd945b0d9bed9185b21dc9f30fb47..947bf8412e6f74ed15e5676c2ad1b803a9dc67bf 100644

--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc

@@ -712,7 +712,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserGetTargets) {

EXPECT_TRUE(target_info->GetString("type", &type));

EXPECT_TRUE(target_info->GetString("title", &title));

EXPECT_TRUE(target_info->GetString("url", &url));

- EXPECT_EQ(type, "web_contents");

+ EXPECT_EQ(type, "page");

EXPECT_EQ(title, "about:blank");

EXPECT_EQ(url, "about:blank");

}