chrome/browser/devtools/devtools_ui_bindings.cc - Issue 2263843002: DevTools: merge devtools target with devtools host, part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2263843002: DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: all done Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('K') | « chrome/browser/devtools/devtools_targets_ui.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index 2ad277b1bba56668abe85e7d22f5767ef4667a3c..8fff9900c07e688cf73b24188857258a91b7d116 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -762,13 +762,13 @@ void DevToolsUIBindings::PerformActionOnRemotePage(const std::string& page_id,

if (!target)

return;

if (action == kRemotePageActionInspect)

- target->Inspect(profile_);

+ target->GetAgentHost()->Inspect();

if (action == kRemotePageActionReload)

- target->Reload();

+ target->GetAgentHost()->Reload();

if (action == kRemotePageActionActivate)

- target->Activate();

+ target->GetAgentHost()->Activate();

if (action == kRemotePageActionClose)

- target->Close();

+ target->GetAgentHost()->Close();

}

void DevToolsUIBindings::OpenRemotePage(const std::string& browser_id,