DevTools: merge devtools target with devtools host, part 1

chrome/browser/devtools/devtools_targets_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_targets_ui.h"
 
 #include <utility>
 
 #include "base/location.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 218 matching lines @@
   SendTargets(DevToolsTargetImpl::EnumerateAll());
 }
 
 void LocalTargetsUIHandler::SendTargets(
     const std::vector<DevToolsTargetImpl*>& targets) {
   base::ListValue list_value;
   std::map<std::string, base::DictionaryValue*> id_to_descriptor;
 
   base::STLDeleteValues(&targets_);
   for (DevToolsTargetImpl* target : targets) {
-    targets_[target->GetId()] = target;
-    id_to_descriptor[target->GetId()] = Serialize(*target);
+    scoped_refptr<content::DevToolsAgentHost> host = target->GetAgentHost();
+    targets_[host->GetId()] = target;
+    id_to_descriptor[host->GetId()] = Serialize(*target);
   }
 
   for (TargetMap::iterator it(targets_.begin()); it != targets_.end(); ++it) {
     DevToolsTargetImpl* target = it->second;
-    base::DictionaryValue* descriptor = id_to_descriptor[target->GetId()];
-    std::string parent_id = target->GetParentId();
+    scoped_refptr<content::DevToolsAgentHost> host = target->GetAgentHost();
+    base::DictionaryValue* descriptor = id_to_descriptor[host->GetId()];
+    std::string parent_id = host->GetParentId();
     if (parent_id.empty() || id_to_descriptor.count(parent_id) == 0) {
       list_value.Append(descriptor);
     } else {
       base::DictionaryValue* parent = id_to_descriptor[parent_id];
       base::ListValue* guests = NULL;
       if (!parent->GetList(kGuestList, &guests)) {
         guests = new base::ListValue();
         parent->Set(kGuestList, guests);
       }
       guests->Append(descriptor);
@@ skipping 103 matching lines @@
           browser->IsChrome() && !parsed.empty() ? parsed[0] : 0);
       std::string browser_id = browser->GetId();
       browser_data->SetString(kTargetIdField, browser_id);
       browser_data->SetString(kTargetSourceField, source_id());
 
       base::ListValue* page_list = new base::ListValue();
       remote_browsers_[browser_id] = browser;
             browser_data->Set(kAdbPagesList, page_list);
       for (const auto& page : browser->pages()) {
         DevToolsTargetImpl* target = android_bridge_->CreatePageTarget(page);
+        scoped_refptr<content::DevToolsAgentHost> host = target->GetAgentHost();
         base::DictionaryValue* target_data = Serialize(*target);
         target_data->SetBoolean(
             kAdbAttachedForeignField,
-            target->IsAttached() &&
-                !android_bridge_->HasDevToolsWindow(target->GetId()));
+            host->IsAttached() &&
+                !android_bridge_->HasDevToolsWindow(host->GetId()));
         // Pass the screen size in the target object to make sure that
         // the caching logic does not prevent the target item from updating
         // when the screen size changes.
         gfx::Size screen_size = device->screen_size();
         target_data->SetInteger(kAdbScreenWidthField, screen_size.width());
         target_data->SetInteger(kAdbScreenHeightField, screen_size.height());
-        targets_[target->GetId()] = target;
+        targets_[host->GetId()] = target;
         page_list->Append(target_data);
       }
       browser_list->Append(std::move(browser_data));
     }
 
     device_list.Append(std::move(device_data));
   }
   SendSerializedTargets(device_list);
 }
 
@@ skipping 42 matching lines @@
 }
 
 scoped_refptr<content::DevToolsAgentHost>
 DevToolsTargetsUIHandler::GetBrowserAgentHost(const std::string& browser_id) {
   return NULL;
 }
 
 base::DictionaryValue* DevToolsTargetsUIHandler::Serialize(
     const DevToolsTargetImpl& target) {
   base::DictionaryValue* target_data = new base::DictionaryValue();
+  scoped_refptr<content::DevToolsAgentHost> host = target.GetAgentHost();
   target_data->SetString(kTargetSourceField, source_id_);
-  target_data->SetString(kTargetIdField, target.GetId());
-  target_data->SetString(kTargetTypeField, target.GetType());
-  target_data->SetBoolean(kAttachedField, target.IsAttached());
-  target_data->SetString(kUrlField, target.GetURL().spec());
-  target_data->SetString(kNameField, target.GetTitle());
-  target_data->SetString(kFaviconUrlField, target.GetFaviconURL().spec());
-  target_data->SetString(kDescriptionField, target.GetDescription());
+  target_data->SetString(kTargetIdField, host->GetId());
+  target_data->SetString(kTargetTypeField, host->GetType());
+  target_data->SetBoolean(kAttachedField, host->IsAttached());
+  target_data->SetString(kUrlField, host->GetURL().spec());
+  target_data->SetString(kNameField, host->GetTitle());
+  target_data->SetString(kFaviconUrlField, host->GetFaviconURL().spec());
+  target_data->SetString(kDescriptionField, host->GetDescription());
   return target_data;
 }
 
 void DevToolsTargetsUIHandler::SendSerializedTargets(
     const base::ListValue& list) {
   callback_.Run(source_id_, list);
 }
 
 void DevToolsTargetsUIHandler::ForceUpdate() {
 }
@@ skipping 34 matching lines @@
     device_status_dict->SetString(kPortForwardingBrowserId,
                                   sit->first->GetId());
 
     std::string device_id = base::StringPrintf(
         kAdbDeviceIdFormat,
         sit->first->serial().c_str());
     result.Set(device_id, device_status_dict);
   }
   callback_.Run(result);
 }