Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/core/html/track/TrackListBase.h

Issue 2263823002: Deliver change notifications to SourceBuffer track lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update activeSourceBuffers on track status changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TrackListBase.h
diff --git a/third_party/WebKit/Source/core/html/track/TrackListBase.h b/third_party/WebKit/Source/core/html/track/TrackListBase.h
index 155eb97b552aa4df7d5266618351d01fd70b843b..ce2063320cc7100045392facec4aa95ae6522f88 100644
--- a/third_party/WebKit/Source/core/html/track/TrackListBase.h
+++ b/third_party/WebKit/Source/core/html/track/TrackListBase.h
@@ -59,7 +59,7 @@ public:
{
track->setMediaElement(m_mediaElement);
m_tracks.append(track);
- scheduleTrackEvent(EventTypeNames::addtrack, track);
+ scheduleEvent(TrackEvent::create(EventTypeNames::addtrack, track));
}
void remove(WebMediaPlayer::TrackId trackId)
@@ -69,7 +69,7 @@ public:
continue;
m_tracks[i]->setMediaElement(0);
- scheduleTrackEvent(EventTypeNames::removetrack, m_tracks[i]);
+ scheduleEvent(TrackEvent::create(EventTypeNames::removetrack, m_tracks[i].get()));
m_tracks.remove(i);
return;
}
@@ -87,8 +87,7 @@ public:
void scheduleChangeEvent()
{
Event* event = Event::create(EventTypeNames::change);
- event->setTarget(this);
- m_mediaElement->scheduleEvent(event);
+ scheduleEvent(event);
mlamouri (slow - plz ping) 2016/08/23 13:12:27 style: sounds like you could write this in one lin
servolk 2016/08/23 17:25:02 Done.
}
Node* owner() const { return m_mediaElement; }
@@ -107,14 +106,14 @@ public:
}
}
-private:
- void scheduleTrackEvent(const AtomicString& eventName, T* track)
+protected:
+ void scheduleEvent(Event* event)
{
- Event* event = TrackEvent::create(eventName, track);
event->setTarget(this);
m_mediaElement->scheduleEvent(event);
}
+private:
HeapVector<Member<T>> m_tracks;
Member<HTMLMediaElement> m_mediaElement;
};

Powered by Google App Engine
This is Rietveld 408576698