Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/html/track/TrackListBase.h

Issue 2263823002: Deliver change notifications to SourceBuffer track lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update activeSourceBuffers on track status changes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TrackListBase_h 5 #ifndef TrackListBase_h
6 #define TrackListBase_h 6 #define TrackListBase_h
7 7
8 #include "core/events/EventTarget.h" 8 #include "core/events/EventTarget.h"
9 9
10 #include "core/html/HTMLMediaElement.h" 10 #include "core/html/HTMLMediaElement.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 { 52 {
53 if (m_mediaElement) 53 if (m_mediaElement)
54 return m_mediaElement->getExecutionContext(); 54 return m_mediaElement->getExecutionContext();
55 return nullptr; 55 return nullptr;
56 } 56 }
57 57
58 void add(T* track) 58 void add(T* track)
59 { 59 {
60 track->setMediaElement(m_mediaElement); 60 track->setMediaElement(m_mediaElement);
61 m_tracks.append(track); 61 m_tracks.append(track);
62 scheduleTrackEvent(EventTypeNames::addtrack, track); 62 scheduleEvent(TrackEvent::create(EventTypeNames::addtrack, track));
63 } 63 }
64 64
65 void remove(WebMediaPlayer::TrackId trackId) 65 void remove(WebMediaPlayer::TrackId trackId)
66 { 66 {
67 for (unsigned i = 0; i < m_tracks.size(); ++i) { 67 for (unsigned i = 0; i < m_tracks.size(); ++i) {
68 if (m_tracks[i]->id() != trackId) 68 if (m_tracks[i]->id() != trackId)
69 continue; 69 continue;
70 70
71 m_tracks[i]->setMediaElement(0); 71 m_tracks[i]->setMediaElement(0);
72 scheduleTrackEvent(EventTypeNames::removetrack, m_tracks[i]); 72 scheduleEvent(TrackEvent::create(EventTypeNames::removetrack, m_trac ks[i].get()));
73 m_tracks.remove(i); 73 m_tracks.remove(i);
74 return; 74 return;
75 } 75 }
76 NOTREACHED(); 76 NOTREACHED();
77 } 77 }
78 78
79 void removeAll() 79 void removeAll()
80 { 80 {
81 for (unsigned i = 0; i < m_tracks.size(); ++i) 81 for (unsigned i = 0; i < m_tracks.size(); ++i)
82 m_tracks[i]->setMediaElement(0); 82 m_tracks[i]->setMediaElement(0);
83 83
84 m_tracks.clear(); 84 m_tracks.clear();
85 } 85 }
86 86
87 void scheduleChangeEvent() 87 void scheduleChangeEvent()
88 { 88 {
89 Event* event = Event::create(EventTypeNames::change); 89 Event* event = Event::create(EventTypeNames::change);
90 event->setTarget(this); 90 scheduleEvent(event);
mlamouri (slow - plz ping) 2016/08/23 13:12:27 style: sounds like you could write this in one lin
servolk 2016/08/23 17:25:02 Done.
91 m_mediaElement->scheduleEvent(event);
92 } 91 }
93 92
94 Node* owner() const { return m_mediaElement; } 93 Node* owner() const { return m_mediaElement; }
95 94
96 DEFINE_INLINE_TRACE() 95 DEFINE_INLINE_TRACE()
97 { 96 {
98 visitor->trace(m_tracks); 97 visitor->trace(m_tracks);
99 visitor->trace(m_mediaElement); 98 visitor->trace(m_mediaElement);
100 EventTargetWithInlineData::trace(visitor); 99 EventTargetWithInlineData::trace(visitor);
101 } 100 }
102 101
103 DECLARE_VIRTUAL_TRACE_WRAPPERS() 102 DECLARE_VIRTUAL_TRACE_WRAPPERS()
104 { 103 {
105 for (auto track : m_tracks) { 104 for (auto track : m_tracks) {
106 visitor->traceWrappers(track); 105 visitor->traceWrappers(track);
107 } 106 }
108 } 107 }
109 108
110 private: 109 protected:
111 void scheduleTrackEvent(const AtomicString& eventName, T* track) 110 void scheduleEvent(Event* event)
112 { 111 {
113 Event* event = TrackEvent::create(eventName, track);
114 event->setTarget(this); 112 event->setTarget(this);
115 m_mediaElement->scheduleEvent(event); 113 m_mediaElement->scheduleEvent(event);
116 } 114 }
117 115
116 private:
118 HeapVector<Member<T>> m_tracks; 117 HeapVector<Member<T>> m_tracks;
119 Member<HTMLMediaElement> m_mediaElement; 118 Member<HTMLMediaElement> m_mediaElement;
120 }; 119 };
121 120
122 } // namespace blink 121 } // namespace blink
123 122
124 #endif 123 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698