Source/core/rendering/shapes/Shape.h - Issue 226373002: [CSS Shapes] shape-margin in percentage units always computes to 0px

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/Shape.h

Issue 226373002: [CSS Shapes] shape-margin in percentage units always computes to 0px (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html ('K') | « Source/core/rendering/shapes/BoxShapeTest.cpp ('k') | Source/core/rendering/shapes/Shape.cpp » ('j') | Source/core/rendering/shapes/ShapeOutsideInfo.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/Shape.h

diff --git a/Source/core/rendering/shapes/Shape.h b/Source/core/rendering/shapes/Shape.h

index 426e822ed022414edb51624f5560e8be8daebd83..3c51dabebcf8640c803a6f79aa4a5dac779169de 100644

--- a/Source/core/rendering/shapes/Shape.h

+++ b/Source/core/rendering/shapes/Shape.h

@@ -61,9 +61,9 @@ typedef Vector<LineSegment> SegmentList;

class Shape {

public:

- static PassOwnPtr<Shape> createShape(const BasicShape*, const LayoutSize& logicalBoxSize, WritingMode, Length margin);

- static PassOwnPtr<Shape> createRasterShape(Image*, float threshold, const LayoutRect& imageRect, const LayoutRect& marginRect, WritingMode, Length margin);

- static PassOwnPtr<Shape> createLayoutBoxShape(const RoundedRect&, WritingMode, const Length& margin);

+ static PassOwnPtr<Shape> createShape(const BasicShape*, const LayoutSize& logicalBoxSize, WritingMode, float margin);

+ static PassOwnPtr<Shape> createRasterShape(Image*, float threshold, const LayoutRect& imageRect, const LayoutRect& marginRect, WritingMode, float margin);

+ static PassOwnPtr<Shape> createLayoutBoxShape(const RoundedRect&, WritingMode, float margin);

virtual ~Shape() { }